Fix rubocop offenses

app/controllers/system_admin/users_controller.rb

@@ -17,7 +17,7 @@ def edit
 
     def create
       @user = User.new(user_params)
-      @user.roles = [] 
+      @user.roles = []
       params[:user][:role_ids].each do |role_id|
         @user.add_role(Role.find(role_id).name) if role_id.present?
       end
@@ -31,7 +31,7 @@ def create
 
     def update
       if @user.update(user_params)
-        @user.roles = [] 
+        @user.roles = []
         params[:user][:role_ids].each do |role_id|
           @user.add_role(Role.find(role_id).name) if role_id.present?
         end

app/models/role.rb

@@ -10,18 +10,17 @@
 #  resource_id   :bigint
 #
 class Role < ApplicationRecord
-  ROLES_LIST = [:spectator, :servant, :manager, :admin, :super_admin]
+  ROLES_LIST = %i[spectator servant manager admin super_admin].freeze
+
+  has_many_through :users, :users_roles
 
-  has_and_belongs_to_many :users, :join_table => :users_roles
-
   belongs_to :resource,
-             :polymorphic => true,
-             :optional => true
-
+             polymorphic: true,
+             optional: true
 
   validates :resource_type,
-            :inclusion => { :in => Rolify.resource_types },
-            :allow_nil => true
+            inclusion: { in: Rolify.resource_types },
+            allow_nil: true
 
   scopify
 end

app/models/user.rb

@@ -11,4 +11,4 @@ class User < ApplicationRecord
   rolify
   audited
   devise :omniauthable, omniauth_providers: %i[azure_activedirectory_v2]
-end
+end

config/initializers/rolify.rb

@@ -4,7 +4,7 @@
 
   # Dynamic shortcuts for User class (user.is_admin? like methods). Default is: false
   # config.use_dynamic_shortcuts
-  
+
   # Configuration to remove roles from database once the last resource is removed. Default is: true
   # config.remove_role_if_empty = false
 end

db/migrate/20231003024901_rolify_create_roles.rb

@@ -2,17 +2,17 @@ class RolifyCreateRoles < ActiveRecord::Migration[7.0]
   def change
     create_table(:roles) do |t|
       t.string :name
-      t.references :resource, :polymorphic => true
+      t.references :resource, polymorphic: true
 
       t.timestamps
     end
 
-    create_table(:users_roles, :id => false) do |t|
+    create_table(:users_roles, id: false) do |t|
       t.references :user
       t.references :role
     end
-    
-    add_index(:roles, [ :name, :resource_type, :resource_id ])
-    add_index(:users_roles, [ :user_id, :role_id ])
+
+    add_index(:roles, %i[name resource_type resource_id])
+    add_index(:users_roles, %i[user_id role_id])
   end
 end

spec/factories/roles.rb

@@ -11,6 +11,6 @@
 #
 FactoryBot.define do
   factory :role do
-
+    name { "Admin" }
   end
 end

spec/models/role_spec.rb

@@ -9,8 +9,8 @@
 #  updated_at    :datetime         not null
 #  resource_id   :bigint
 #
-require 'rails_helper'
+require "rails_helper"
 
-RSpec.describe Role, type: :model do
+RSpec.describe Role do
   it { is_expected.to have_db_column(:name) }
 end