Rename Rejection Details column to Comments (#282)

app/controllers/system_admin/applicants_controller.rb

@@ -53,7 +53,7 @@ def applicant_params
         :payment_confirmation_completed_at,
         :rejection_completed_at,
         :rejection_reason,
-        :rejection_details,
+        :comments,
       )
     end
 

app/models/application_progress.rb

@@ -6,11 +6,11 @@
 #
 #  id                                :bigint           not null, primary key
 #  banking_approval_completed_at     :date
+#  comments                          :text
 #  home_office_checks_completed_at   :date
 #  initial_checks_completed_at       :date
 #  payment_confirmation_completed_at :date
 #  rejection_completed_at            :date
-#  rejection_details                 :text
 #  rejection_reason                  :integer
 #  school_checks_completed_at        :date
 #  school_investigation_required     :boolean          default(FALSE), not null

app/models/reports/qa_report.rb

@@ -60,7 +60,7 @@ def rejection_rows(app)
 
       [
         app.application_progress.rejection_reason&.humanize,
-        app.application_progress.rejection_details,
+        app.application_progress.comments,
       ]
     end
 

app/views/system_admin/applicants/edit.html.erb

@@ -32,7 +32,7 @@
       <%= f.govuk_date_field :payment_confirmation_completed_at, legend: { text: "Payment Confirmation (payslip)", size: "s" } %>
       <%= f.govuk_date_field :rejection_completed_at, legend: { text: "Rejection Date", size: "s" } %>
       <%= f.govuk_select :rejection_reason, rejection_reasons, label: { text: "Rejection Reason" } %>
-      <%= f.govuk_text_area :rejection_details, label: { text: 'Rejection Details' }, rows: 3 %>
+      <%= f.govuk_text_area :comments, label: { text: 'Comments' }, rows: 3 %>
 
       <%= f.govuk_submit("Update") %>
     <% end %>

app/views/system_admin/applicants/show.html.erb

@@ -58,8 +58,8 @@
       row.with_value(text: @progress.rejection_reason&.humanize ) 
     end
     summary_list.with_row do |row|
-      row.with_key(text: 'Rejection Details')
-      row.with_value(text: @progress.rejection_details ) 
+      row.with_key(text: 'Comments')
+      row.with_value(text: @progress.comments ) 
     end
   end
 end %>

db/migrate/20231002115920_rename_rejection_details_to_comments.rb

@@ -0,0 +1,5 @@
+class RenameRejectionDetailsToComments < ActiveRecord::Migration[7.0]
+  def change
+    rename_column :application_progresses, :rejection_details, :comments
+  end
+end

spec/factories/application_progresses.rb

@@ -4,11 +4,11 @@
 #
 #  id                                :bigint           not null, primary key
 #  banking_approval_completed_at     :date
+#  comments                          :text
 #  home_office_checks_completed_at   :date
 #  initial_checks_completed_at       :date
 #  payment_confirmation_completed_at :date
 #  rejection_completed_at            :date
-#  rejection_details                 :text
 #  rejection_reason                  :integer
 #  school_checks_completed_at        :date
 #  school_investigation_required     :boolean          default(FALSE), not null

spec/features/admin_console/update_progress_spec.rb

@@ -93,7 +93,7 @@ def when_i_submit_a_rejection_with_reason
   def when_i_submit_a_rejection_with_reason_and_details
     fill_in_rejection_date
     select "Suspected fraud", from: "application_progress[rejection_reason]"
-    fill_in "application_progress[rejection_details]", with: "suspected_fraud"
+    fill_in "application_progress[comments]", with: "I suspected fraud on this application"
     click_button "Update"
   end
 

spec/models/application_progress_spec.rb

@@ -4,11 +4,11 @@
 #
 #  id                                :bigint           not null, primary key
 #  banking_approval_completed_at     :date
+#  comments                          :text
 #  home_office_checks_completed_at   :date
 #  initial_checks_completed_at       :date
 #  payment_confirmation_completed_at :date
 #  rejection_completed_at            :date
-#  rejection_details                 :text
 #  rejection_reason                  :integer
 #  school_checks_completed_at        :date
 #  school_investigation_required     :boolean          default(FALSE), not null

spec/models/reports/qa_report_spec.rb

@@ -48,8 +48,7 @@ module Reports
         let(:status) { "rejected" }
 
         it "returns the data including rejection reasons in CSV format" do
-          application = create(:application, application_progress: build(:application_progress, rejection_completed_at: Time.zone.now, status: :rejected, rejection_reason: :request_to_re_submit, rejection_details: "Some details"))
-
+          application = create(:application, application_progress: build(:application_progress, rejection_completed_at: Time.zone.now, status: :rejected, rejection_reason: :request_to_re_submit, comments: "Some details"))
           expect(report.csv).to include([
             application.urn,
             application.applicant.full_name,
@@ -66,7 +65,7 @@ module Reports
             application.visa_type,
             application.date_of_entry.strftime("%d/%m/%Y"),
             application.application_progress.rejection_reason&.humanize,
-            application.application_progress.rejection_details,
+            application.application_progress.comments,
           ].join(","))
         end
       end