[CAPT-1999] Rails 8 #3442
[CAPT-1999] Rails 8 #3442
Conversation
| def calculate_plan_type_of_deduction(value) | ||
| if value == "No data" | ||
| nil | ||
| else | ||
| value | ||
| end | ||
| end | ||
|
|
||
| def calculate_no_of_plans_currently_repaying(value) | ||
| if value == "No data" | ||
| nil | ||
| else | ||
| value | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
I'm not familiar in this area. can some confirm if this is desired? are there other instances of this that need to be addressed that are potentially missing coverage?
There was a problem hiding this comment.
I'm not familiar on this bit of code, seems weird that a version upgrade would change this behaviour!
There was a problem hiding this comment.
for posterity this change issue was introduced by rails/rails@366909d#diff-3f89af7ff219385718b7c0e4635cc4190476349db18f8bf80fb84fa1e7f5e289L240
adding the casting our side is by far a better option and we simply got lucky before it was doing our desired behaviour by default
| def calculate_plan_type_of_deduction(value) | ||
| if value == "No data" | ||
| nil | ||
| else | ||
| value | ||
| end | ||
| end | ||
|
|
||
| def calculate_no_of_plans_currently_repaying(value) | ||
| if value == "No data" | ||
| nil | ||
| else | ||
| value | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
I'm not familiar on this bit of code, seems weird that a version upgrade would change this behaviour!
- continues to use current existing behaviour of :offset
Context
Notes
config.active_support.to_time_preserves_timezonethe deprecation warning is still present. from what I can tell it seems to be issue with how the deprecation warning code implemented and should be fine to ignore