Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade govuk frontend 5.6.0 => 5.7.1 #3440

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Upgrade govuk frontend 5.6.0 => 5.7.1 #3440

merged 1 commit into from
Nov 28, 2024
+21 −12

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Nov 28, 2024

Notes

  • This is a prerequisite to upgrading to rails 8

@asmega asmega added the deploy Deploy a review app for this PR label Nov 28, 2024
@asmega asmega changed the title Upgrade govuk frontend 5.6.0 => 5.7 Upgrade govuk frontend 5.6.0 => 5.7.1 Nov 28, 2024
This was referenced Nov 28, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3440-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3440-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3440-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3440-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3440-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3440-web.test.teacherservices.cloud/admin

@asmega asmega marked this pull request as ready for review November 28, 2024 11:46
rjlynch
rjlynch approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, doesn't seem to be any breaking changes, review app looks fine

@asmega asmega merged commit 0ae7ce3 into master Nov 28, 2024
17 checks passed
@asmega asmega deleted the govuk-5-7-1 branch November 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

@kenfodder kenfodder kenfodder approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmega @kenfodder @rjlynch