[CAPT-2030] Fix EY started_at timestamp #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
approved these changes
Nov 28, 2024
| def build_claim | ||
| existing_or_new_claim.tap do |claim| | ||
| claim.eligibility ||= main_eligibility | ||
| claim.eligibility.practitioner_claim_started_at = journey_session.answers.practitioner_claim_started_at |
There was a problem hiding this comment.
Suggested change
| claim.eligibility.practitioner_claim_started_at = journey_session.answers.practitioner_claim_started_at |
Do we need this line? Is this not handled by the set_eligibility_attributes in the base class?
There was a problem hiding this comment.
- I just tried and is needed and evident with failing test
- the provider has already created the claim and eligibility at this time
- unlike the other journeys where claim and eligibility are created once
- therefore it skips
main_eligibilityon the line above (27) - which would have called
set_eligibility_attributeswhich you mentioned
There was a problem hiding this comment.
tbh the existing code its a little bit spaghetti and a bit of a roundabout way. could probably delete most of the stuff and be explicit on what is needed, i think moving away from inheritance would help this
asmega
force-pushed
the
fix-ey-meta-timestamps
branch
from
5cb441b to
d525be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context