Reminders store journey #3436
Merged
Reminders store journey #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
force-pushed
the
reminder-store-journey
branch
from
f557f8c to
dd565f0
Compare
asmega
commented
Nov 26, 2024
Comment on lines
+6
to
+17
| around do |example| | ||
| original_stdout = $stdout | ||
| original_stderr = $stderr | ||
|
|
||
| $stdout = File.open(File::NULL, "w") | ||
| $stderr = File.open(File::NULL, "w") | ||
|
|
||
| example.run | ||
|
|
||
| $stdout = original_stdout | ||
| $stderr = original_stderr | ||
| end |
There was a problem hiding this comment.
i want to slow tidy stdout when rspec runs
There was a problem hiding this comment.
Should probably just delete this spec and the rake task as it seems to be a one off task https://dfedigital.atlassian.net.mcas.ms/browse/CAPT-1877
rjlynch
reviewed
Nov 28, 2024
Comment on lines
+6
to
+17
| around do |example| | ||
| original_stdout = $stdout | ||
| original_stderr = $stderr | ||
|
|
||
| $stdout = File.open(File::NULL, "w") | ||
| $stderr = File.open(File::NULL, "w") | ||
|
|
||
| example.run | ||
|
|
||
| $stdout = original_stdout | ||
| $stderr = original_stderr | ||
| end |
There was a problem hiding this comment.
Should probably just delete this spec and the rake task as it seems to be a one off task https://dfedigital.atlassian.net.mcas.ms/browse/CAPT-1877
asmega
force-pushed
the
reminder-store-journey
branch
from
dd565f0 to
a2e544b
Compare
- this is still currently limited to additional payments - there is guard for the above - but can be extended allow for other journeys - this change is based on PR #3175
asmega
force-pushed
the
reminder-store-journey
branch
from
e4c161e to
1c66fb9
Compare
- as this seems to conflict with active job serialisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context