Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUPEYALPHA-1112] When no entry in SLC data, do not create task (shows as incomplete on admin view) #3251

Merged

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Oct 1, 2024

All journeys now behave the same (except TSLR which does not have a student loan plan task):

  • when the claim is submitted, and there is no SLC data for the claimant, the task shows as 'Incomplete'
  • when the SLC data is subsequently uploaded, the 'Incomplete' tasks will show as 'Passed' or 'Incomplete' depending if a SLC data entry has been found for that claimant
  • when the claim is submitted, and there is SLC data for the claimant, the task does not show, but the plan is set correctly

For the 'Incomplete' student loan plan tasks, I've added the notes back, as that shows if the automated check was carried out (it used to show on the old 'No data' tasks).

We don't show 'No data' for student loan plan tasks any more - it's either 'Incomplete' or 'Passed'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored this spec - it was testing too much, checking for tasks and notes, and the wording was confusing.
It now just checks if the ClaimStudentLoanDetailsUpdater and AutomatedChecks::ClaimVerifiers::StudentLoanPlan are called correctly.

@alkesh alkesh added the deploy Deploy a review app for this PR label Oct 1, 2024
@alkesh alkesh force-pushed the LUPEYALPHA-1112-student-loan-plan-task-for-additional-payments branch from 07cee20 to 4926c5d Compare October 8, 2024 13:32
@alkesh alkesh force-pushed the LUPEYALPHA-1112-student-loan-plan-task-for-additional-payments branch from 4926c5d to f0cee3f Compare October 8, 2024 16:24
@alkesh alkesh force-pushed the LUPEYALPHA-1112-student-loan-plan-task-for-additional-payments branch from f0cee3f to 7593be9 Compare October 9, 2024 15:56
@alkesh alkesh merged commit 78e16e4 into master Oct 9, 2024
14 checks passed
@alkesh alkesh deleted the LUPEYALPHA-1112-student-loan-plan-task-for-additional-payments branch October 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants