Fix flakey test #3229
Merged
Fix flakey test #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenfodder
approved these changes
Sep 25, 2024
alkesh
reviewed
Sep 25, 2024
| expect(page.find("table")).to have_content("ECP").exactly(10).times | ||
| expect(page.find("table")).to have_content("TSLR").exactly(7).times | ||
| expect(page.find("table")).to have_content("STRI").exactly(2).times | ||
| expect(page.find("table")).to have_content("FE").exactly(2).times |
There was a problem hiding this comment.
I came across this recently too on my ticket.
My solution was:
expect(page).to have_selector("td[text()='ECP']", count: 10)
The only advantage to this is that it copes if columns are added/removed from this table, as it doesn't assume a column number.
There was a problem hiding this comment.
Yeah that's nicer, have changed
alkesh
approved these changes
Sep 25, 2024
Sometimes the string "FE" ends up in the generated claim reference, eg "XBCFEA", and so is visible in the table more than twice. To fix this we need to specifically look in the policy short names column.
rjlynch
force-pushed
the
fix-flakey-admin-spec
branch
from
8f932b3 to
eb215fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the string "FE" ends up in the generated claim reference, eg "XBCFEA", and so is visible in the table more than twice. To fix this we need to specifically look in the policy short names column.