Add teaching hours task #3062
Merged
Add teaching hours task #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
approved these changes
Aug 6, 2024
asmega
reviewed
Aug 6, 2024
| @@ -29,6 +29,7 @@ def applicable_task_names | |||
| task_names.delete("employment_contract") | |||
| task_names.delete("employment_start") | |||
| task_names.delete("subject") | |||
| task_names.delete("teaching_hours") | |||
There was a problem hiding this comment.
not related to your change but think this class could do with some changes as a whole. be great if we could delegate these to some other classes and switchover from a blacklisting to a whitelist approach, i think would make this so much more readable
There was a problem hiding this comment.
Yeah I agree, I think these should be moved into the policy as they're policy specific, and would match how we handle admin claim rejection reasons
rjlynch
force-pushed
the
CAPT-1497/minimum-teaching-task
branch
from
a93dd22 to
92d14f9
Compare
IRP requires we check with the school how much time the claimant spends teaching specific subjects. We don't ask this question in the eligibility, so in the admin presenter we reshow the teaching subject for this task.
rjlynch
force-pushed
the
CAPT-1497/minimum-teaching-task
branch
from
92d14f9 to
90d3905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRP requires we check with the school how much time the claimant spends
teaching specific subjects. We don't ask this question in the
eligibility, so in the admin presenter we reshow the teaching subject
for this task.