support validating OTP without a generated_at time and with a specified secret #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkesh
force-pushed
the
one-time-password-refactor
branch
from
4b46af8 to
3aa13dc
Compare
alkesh
commented
Aug 6, 2024
| end | ||
|
|
||
| private | ||
|
|
||
| attr_reader :code, :generated_at | ||
|
|
||
| def wrong_length? | ||
| return @wrong_length if defined?(@wrong_length) | ||
|
|
||
| @wrong_length = code.gsub(/\D/, "").length != LENGTH |
There was a problem hiding this comment.
I'm not sure what this was ever doing - ignoring non-digits when checking for length doesn't seem useful.
e.g. code "1234A5B6" would have the correct length in this case, but would still not be a valid code (it still fails the ROTP:TOTP#verify)
alkesh
force-pushed
the
one-time-password-refactor
branch
from
3aa13dc to
a5c7cfe
Compare
kenfodder
reviewed
Aug 6, 2024
alkesh
force-pushed
the
one-time-password-refactor
branch
from
a5c7cfe to
1126e06
Compare
asmega
reviewed
Aug 7, 2024
alkesh
changed the title
alkesh
force-pushed
the
one-time-password-refactor
branch
from
c5a07b5 to
30200c9
Compare
asmega
reviewed
Aug 8, 2024
Comment on lines
+6
to
+7
| let!(:one_time_passcode) { OneTimePassword::Generator.new.code } | ||
| let!(:generated_at) { Time.now } |
There was a problem hiding this comment.
not blocking but don't see why these can't be lazy ie let instead of let!
There was a problem hiding this comment.
because I have a spec that uses travel to move 20 minutes into the future, to test for passcode expiry.
asmega
reviewed
Aug 8, 2024
asmega
approved these changes
Aug 8, 2024
alkesh
force-pushed
the
one-time-password-refactor
branch
from
30200c9 to
a007cdf
Compare
alkesh
force-pushed
the
one-time-password-refactor
branch
from
a007cdf to
65c5481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need 2 changes to the OTP code for the EY magic link:
generated_attime.