CAPT-1689 Add start date form #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1689/irp/start-date
branch
2 times, most recently
from
964267c to
d24a25a
Compare
rjlynch
force-pushed
the
CAPT-1689/irp/start-date
branch
from
d24a25a to
9b80b10
Compare
felixclack
approved these changes
Jun 24, 2024
app/views/get_a_teacher_relocation_payment/claims/start_date.html.erb
Outdated
Show resolved
Hide resolved
spec/forms/journeys/get_a_teacher_relocation_payment/start_date_form_spec.rb
Outdated
Show resolved
Hide resolved
Adds the form to capture the start date. Of note is the use of `_assign_attributes`. ActiveModel doesn't support multi part parameters so we need to include `ActiveRecord::AttributeAssignment` to get them. This behaviour should probably be upstreamed into the base Form class and the personal details form migrated to set it's mutli part parameters with this approach, though changing the attribute assignment in the base form to support this felt out of scope of this commit. Also this commit doesn't add the eligibility checking for invalid contract dates. We're waiting on the product team to get back to us with what this should be. When they have we'll enable the feature tests for the ineligibility.
rjlynch
force-pushed
the
CAPT-1689/irp/start-date
branch
from
9b80b10 to
c9a4a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the form to capture the start date. Of note is the use of
_assign_attributes. ActiveModel doesn't support multi part parameters so we need to includeActiveRecord::AttributeAssignmentto get them. This behaviour should probably be upstreamed We may want to upstream this behaviour into the base Form class though changing the attribute assignment in the base form to support this felt out of scope of this commit.Also this commit doesn't add the eligibility checking for invalid contract dates. We're waiting on the product team to get back to us with what this should be. When they have we'll enable the feature tests for the ineligibility.
contract-start-date.mov