[CAPT-1729] use GOVUK formbuilder for existing session form #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
commented
Jun 21, 2024
Comment on lines
+5
to
+8
| <% radio_options = [ | ||
| OpenStruct.new(id: true, name: "Yes, start claim #{journey_description(current_journey_routing_name)} and lose my progress on my first claim"), | ||
| OpenStruct.new(id: false, name: "No, finish the claim I have in progress"), | ||
| ] %> |
There was a problem hiding this comment.
i think leaving this inline for now is sufficient. we may want to switch to a view component at a later date but starting to get diminishing returns for effort spent
felixclack
approved these changes
Jun 24, 2024
asmega
force-pushed
the
minor-form-tweaks-12
branch
from
354a975 to
816d6c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
existing sessionspage to use GOVUK form builder