[CAPT-1729] Use GOVUK formbuilder for multiple eligibility #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
reviewed
Jun 20, 2024
| and | ||
| <%= link_to "levelling up premium payments (opens in new tab)", Policies::LevellingUpPremiumPayments.eligibility_page_url, class: "govuk-link govuk-link--no-visited-state", target: "_blank" %>. | ||
| <%= govuk_link_to "levelling up premium payments (opens in new tab)", Policies::LevellingUpPremiumPayments.eligibility_page_url, no_visited_state: true, target: "_blank" %>. |
There was a problem hiding this comment.
Don't mean to butt in just saw this PR in the feed - you can use the recently-added new_tab: true which automatically appends (opens in new tab) and also sets the rel and target attrs. More info here.
There was a problem hiding this comment.
@peteryates no not all, I've made your suggested change here. Thanks again for the great library and making our lives easier!
felixclack
approved these changes
Jun 20, 2024
| @@ -18,6 +20,16 @@ def save | |||
| journey_session.save! | |||
| end | |||
|
|
|||
| def radio_options | |||
app/views/additional_payments/claims/_eligibility_confirmed_multiple.html.erb
Outdated
Show resolved
Hide resolved
app/views/additional_payments/claims/eligibility_confirmed.html.erb
Outdated
Show resolved
Hide resolved
asmega
force-pushed
the
minor-form-tweaks-11
branch
from
0c444a9 to
9669544
Compare
asmega
force-pushed
the
minor-form-tweaks-11
branch
from
9669544 to
4fafe83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
GOVUKDesignSystemFormBuilder::FormBuilderfor multiple eligibility form