CAPT-1702 Migrate test environment to AKS #2815

AbigailMcP · 2024-06-07T13:51:50Z

Changes in this PR

Create test environment, so we can have proper testing before deploying to production

Guidance to review

Run make test-aks terraform-plan-aks and check output is correct

Testing URLS (created by running make commands locally):

https://claim-additional-payments-for-teaching-test-web.test.teacherservices.cloud/additional-payments/claim
https://claim-additional-payments-for-teaching-test-web.test.teacherservices.cloud/student-loads/claim
https://claim-additional-payments-for-teaching-test-web.test.teacherservices.cloud/admin

github-actions · 2024-06-07T13:52:22Z

Review app deployed to https://s118d02-app-pr-2815-as.azurewebsites.net/additional-payments/claim

slorek · 2024-06-10T16:39:28Z

Had a look at the currently deployed test environment:

We need to add claim-additional-payments-for-teaching-test-web.test.teacherservices.cloud to the DfE Sign In white list on their test environment (unable to log in to admin)
I'm getting 404 errors on /additional-payments/landing-page and /additional-payments/claim

AbigailMcP · 2024-06-12T10:27:12Z

Tested and working:
✅ Basic auth
✅ Claim submission
✅ Exception reporting to Rollbar
✅ Ordnance survey API address lookup
✅ Notify emails sent
✅ Checked application and deployment logs for errors
✅ DQT integration (tested in rails console)

Issues:
✅ DfE Identity sign in
~~the specified 'redirect_uri' is not valid for this client application~~
~~@AbigailMcP whitelisting requested~~
working now, flow tested

✅ Admin login with DfE Sign In
~~redirect_uri did not match any of the client's registered redirect_uris~~
~~whitelisting requested~~
redirect uri added, working now

✅ HMRC API integration
~~@AbigailMcP - updated client secret, needs redeploy to test~~
working now

Untested (need admin login):
🟠 Levelling Up Premium Payments awards upload
🟠 TPS data upload
🟠 School data import

Other things needed:

Testing of the deploy workflow - @vacabor
BigQuery integration - @AbigailMcP
StatusCake integration - made new ticket
Update documentation (accessing cluster, running rake tasks etc) - made new ticket

github-actions · 2024-06-14T10:32:22Z

Deployments

Journey	URL
Additional Payments	https://claim-additional-payments-for-teaching-review-2815-web.test.teacherservices.cloud/additional-payments/claim
Student Loans	https://claim-additional-payments-for-teaching-review-2815-web.test.teacherservices.cloud/student-loans/claim
Admin	https://claim-additional-payments-for-teaching-review-2815-web.test.teacherservices.cloud/admin

RMcVelia · 2024-06-17T10:55:57Z

terraform/application/config/test.tfvars.json

+  "canonical_hostname": "claim-additional-payments-for-teaching-test-web.test.teacherservices.cloud",
+  "startup_command": ["/bin/sh", "-c", "bin/rails server -b 0.0.0.0"],
+  "worker_command": ["/bin/sh", "-c", "bin/bundle exec bin/delayed_job run -n 4"]
+}


the claim-additional-payments-for-teaching-test-web deployment should have 2 replicas

RMcVelia · 2024-06-17T11:03:44Z

.github/workflows/build_and_deploy.yml

+        shell: bash
+        run: |
+          make ci test-aks get-cluster-credentials
+          kubectl exec -n srtl-test deployment/claim-additional-payments-for-teaching-test-worker -- sh -c "DISABLE_DATABASE_ENVIRONMENT_CHECK=1 bin/prepare-database"


We normally have a smoke test post deployment for permanent env deployments (i.e. test/prod), and also look to have a slack msg generated on workflow failure (of perm env deploy/smoke test failure)

smoke test PR: #2875

slack message PR: #2864

vacabor · 2024-06-19T09:18:23Z

terraform/application/variables.tf

+variable "app_replicas" {
+  description = "Number of replicas of the web app"
+  default = 1
+}


Wonder about calling this web_replicas to match the web_application/worker_application convention - I need to introduce worker_replicas in production to scale them independently...

that sounds like a good way to go! i'll update :)

This reverts commit 2d0b531.

* Add slack notification on failure step to build_and_deploy workflow * Remove old slack-alert

* Add smoke test * Run in workflow * Update rspec command to not run smoke tests automatically

AbigailMcP force-pushed the CAPT-1702-migrate-test-environment-to-aks branch from a4267ec to b9b0cde Compare June 7, 2024 13:52

RMcVelia force-pushed the 1853-claims-create-test-env-base-resources branch 2 times, most recently from bd5a1a7 to 21a21a5 Compare June 10, 2024 07:59

Base automatically changed from 1853-claims-create-test-env-base-resources to master June 10, 2024 08:05

AbigailMcP force-pushed the CAPT-1702-migrate-test-environment-to-aks branch from b9b0cde to 78cedf7 Compare June 10, 2024 08:34

AbigailMcP marked this pull request as ready for review June 10, 2024 10:20

AbigailMcP force-pushed the CAPT-1702-migrate-test-environment-to-aks branch from ab4b726 to 5d06201 Compare June 12, 2024 15:23

AbigailMcP added the deploy Deploy a review app for this PR label Jun 14, 2024

AbigailMcP temporarily deployed to review-aks June 14, 2024 10:30 — with GitHub Actions Inactive

vacabor temporarily deployed to review-aks June 14, 2024 13:05 — with GitHub Actions Inactive

AbigailMcP requested review from slorek and RMcVelia June 17, 2024 10:29

slorek approved these changes Jun 17, 2024

View reviewed changes

RMcVelia reviewed Jun 17, 2024

View reviewed changes

AbigailMcP temporarily deployed to review-aks June 17, 2024 12:25 — with GitHub Actions Inactive

vacabor temporarily deployed to review-aks June 17, 2024 13:25 — with GitHub Actions Inactive

vacabor temporarily deployed to review-aks June 18, 2024 11:21 — with GitHub Actions Inactive

vacabor mentioned this pull request Jun 18, 2024

Configure the Semantic Logger to output JSON #2876

Merged

AbigailMcP had a problem deploying to review-aks June 18, 2024 14:08 — with GitHub Actions Failure

AbigailMcP had a problem deploying to review-aks June 18, 2024 15:12 — with GitHub Actions Failure

vacabor reviewed Jun 19, 2024

View reviewed changes

vacabor mentioned this pull request Jun 20, 2024

CAPT-1703 Migrate production environment to AKS #2887

Merged

AbigailMcP had a problem deploying to review-aks June 20, 2024 09:16 — with GitHub Actions Failure

AbigailMcP removed the deploy Deploy a review app for this PR label Jun 20, 2024

AbigailMcP temporarily deployed to review-aks June 20, 2024 10:34 — with GitHub Actions Inactive

AbigailMcP force-pushed the CAPT-1702-migrate-test-environment-to-aks branch from 71901c2 to 79b655f Compare June 20, 2024 13:36

AbigailMcP force-pushed the CAPT-1702-migrate-test-environment-to-aks branch from 79b655f to e9bc91a Compare June 21, 2024 09:22

AbigailMcP and others added 14 commits June 21, 2024 10:44

Add test env variables

715603d

Add startup commands and test_app_env.yml

1269193

Add test deploy to workflow

9f2bdd6

Update canonical_hostname and add postgres extensions

52c7332

Update build_and_deploy workflow to run on push to master, not main

4d98c02

Run DB migrations when deploying the test environment

09dbda2

Add 2 app replicas

1aa731a

Configure SemanticLogger per tech guidance

6db8713

Revert "Configure SemanticLogger per tech guidance"

b5bfd33

This reverts commit 2d0b531.

Use app_replicas variable in web_application module

c5d2de5

CAPT-1702 Add slack notification on failure (#2864)

66fbeef

* Add slack notification on failure step to build_and_deploy workflow * Remove old slack-alert

Rename app_replicas => web_replicas

184e80d

Update worker command

c8f9f3e

CAPT-1702 Add smoke test (#2875)

d3cd5c4

* Add smoke test * Run in workflow * Update rspec command to not run smoke tests automatically

AbigailMcP force-pushed the CAPT-1702-migrate-test-environment-to-aks branch from e9bc91a to d3cd5c4 Compare June 21, 2024 09:44

AbigailMcP merged commit a4b19f4 into master Jun 21, 2024
16 checks passed

AbigailMcP deleted the CAPT-1702-migrate-test-environment-to-aks branch June 21, 2024 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CAPT-1702 Migrate test environment to AKS #2815

CAPT-1702 Migrate test environment to AKS #2815

AbigailMcP commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024

slorek commented Jun 10, 2024

AbigailMcP commented Jun 12, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024

RMcVelia Jun 17, 2024

RMcVelia Jun 17, 2024

AbigailMcP Jun 20, 2024 •

edited

Loading

AbigailMcP Jun 20, 2024

vacabor Jun 19, 2024

AbigailMcP Jun 20, 2024

AbigailMcP Jun 20, 2024

CAPT-1702 Migrate test environment to AKS #2815

CAPT-1702 Migrate test environment to AKS #2815

Conversation

AbigailMcP commented Jun 7, 2024 • edited Loading

Changes in this PR

Guidance to review

github-actions bot commented Jun 7, 2024

slorek commented Jun 10, 2024

AbigailMcP commented Jun 12, 2024 • edited Loading

github-actions bot commented Jun 14, 2024

Deployments

RMcVelia Jun 17, 2024

Choose a reason for hiding this comment

RMcVelia Jun 17, 2024

Choose a reason for hiding this comment

AbigailMcP Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

AbigailMcP Jun 20, 2024

Choose a reason for hiding this comment

vacabor Jun 19, 2024

Choose a reason for hiding this comment

AbigailMcP Jun 20, 2024

Choose a reason for hiding this comment

AbigailMcP Jun 20, 2024

Choose a reason for hiding this comment

AbigailMcP commented Jun 7, 2024 •

edited

Loading

AbigailMcP commented Jun 12, 2024 •

edited

Loading

AbigailMcP Jun 20, 2024 •

edited

Loading