-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maintenance Page Functionality #2473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neillturner
force-pushed
the
origin/maintenance-page
branch
from
October 29, 2024 13:26
df60938
to
ff32bea
Compare
RMcVelia
reviewed
Oct 29, 2024
maintenance_page/manifests/production/ingress_external_to_main.yml
Outdated
Show resolved
Hide resolved
maintenance_page/manifests/production/ingress_internal_to_main.yml
Outdated
Show resolved
Hide resolved
neillturner
force-pushed
the
origin/maintenance-page
branch
from
October 30, 2024 11:52
ae08328
to
cb6708f
Compare
RMcVelia
reviewed
Oct 30, 2024
maintenance_page/manifests/maintenance/deployment_maintenance.yml
Outdated
Show resolved
Hide resolved
neillturner
force-pushed
the
origin/maintenance-page
branch
from
October 30, 2024 15:25
cb6708f
to
ebfeecc
Compare
RMcVelia
approved these changes
Oct 31, 2024
Hassanmir92
reviewed
Oct 31, 2024
type: choice | ||
options: | ||
- test | ||
- production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have preproduction as an option here too.
Our DR testing will be done on that environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Show a friendly message to users when the service is down
Changes proposed in this pull request
Guidance to review
i retested the workflow
see https://github.com/DFE-Digital/apply-for-qualified-teacher-status/actions/runs/11609667671
and tested the maintenance page came up and app was available on temp url
and
https://github.com/DFE-Digital/apply-for-qualified-teacher-status/actions/runs/11609705432
and tested the maintenance page now gone and app was available again
review changes and test doing the following:
To test workflow - enable
wait a couple of mins
To test workflow - disable
https://apply-for-qts-temp.test.teacherservices.cloud - should not exist
https://apply-for-qts-test-web.test.teacherservices.cloud/ - should show show app
get PIM Access to test
get a github token as per Maintenance page
wait a couple of mins
To test makefile disable
wait a couple of mins
Link to Trello card
AFQTS: maintenance page
Checklist