Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maintenance Page Functionality #2473

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

neillturner
Copy link
Contributor

@neillturner neillturner commented Oct 29, 2024

Context

Show a friendly message to users when the service is down

Changes proposed in this pull request

Guidance to review

i retested the workflow
see https://github.com/DFE-Digital/apply-for-qualified-teacher-status/actions/runs/11609667671
and tested the maintenance page came up and app was available on temp url
and
https://github.com/DFE-Digital/apply-for-qualified-teacher-status/actions/runs/11609705432
and tested the maintenance page now gone and app was available again

review changes and test doing the following:

To test workflow - enable

get PIM Access to test

gh auth login

gh workflow run "Set maintenance mode" -r "origin/maintenance-page" -f environment=test -f mode=enable

wait a couple of mins

https://apply-for-qts-temp.test.teacherservices.cloud - should show app

https://apply-for-qts-test-web.test.teacherservices.cloud/ - should show test page

To test workflow - disable

 gh workflow run "Set maintenance mode" -r "origin/maintenance-page" -f environment=test -f mode=disable
``
wait a couple of mins 

https://apply-for-qts-temp.test.teacherservices.cloud - should not exist

https://apply-for-qts-test-web.test.teacherservices.cloud/ - should show show app


#### To test makefile enable

get PIM Access to test

get a github token as per Maintenance page

make test enable-maintenance GITHUB_TOKEN=xxxxxxx

wait a couple of mins

https://apply-for-qts-temp.test.teacherservices.cloud - should show app

https://apply-for-qts-test-web.test.teacherservices.cloud/ - should show test page

To test makefile disable

make test disable-maintenance GITHUB_TOKEN=xxxxxxx

wait a couple of mins

https://apply-for-qts-temp.test.teacherservices.cloud - should not exist

https://apply-for-qts-test-web.test.teacherservices.cloud/ - should show show app

Link to Trello card

AFQTS: maintenance page

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

type: choice
options:
- test
- production
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have preproduction as an option here too.

Our DR testing will be done on that environment.

@neillturner neillturner merged commit d72c7b8 into main Oct 31, 2024
15 checks passed
@neillturner neillturner deleted the origin/maintenance-page branch October 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants