AQTS230 Save failed emails to MailDeliveryFailure table #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed87
force-pushed
the
AQTS-230-modify-MailDeliveryJob
branch
from
03a80a4 to
6a0ab77
Compare
syed87
force-pushed
the
AQTS-230-modify-MailDeliveryJob
branch
2 times, most recently
from
fcd2f85 to
ddc005c
Compare
thomasleese
reviewed
Aug 16, 2024
app/mailers/application_mailer.rb
Outdated
| raise | ||
| end | ||
|
|
||
| def notify_email(headers) |
There was a problem hiding this comment.
Do we need this method here? It looks like a convenience method for calling view_mail with the template ID already provided, but it's not used anywhere.
There was a problem hiding this comment.
It was originally going to add the mailer_action_method and mailer_class to the header but that was done automatically. However It's still used in the application mailer spec on line 15 to set some dummy info.
There was a problem hiding this comment.
I don't think we should have a method that's only used by the tests, I'd suggest the tests can be updated to call view_mail directly like our other mailers to:
view_mail(GOVUK_NOTIFY_TEMPLATE_ID, to: "[email protected]", subject: "Some subject")
syed87
changed the title
Hassanmir92
approved these changes
Sep 3, 2024
syed87
force-pushed
the
AQTS-230-modify-MailDeliveryJob
branch
from
52bce21 to
bc18745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket
MailDeliveryFailure model has been merged into the codebase, this pr will provide the functionality to create entries for the table by recording errors when sending emails.