Reset requested date when changing reference request email addresses #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how it is sent to use the after_requested method which is automatically called from the RequestRequestable service.
This clarifies the transactions and ensures that we can update as much as possible.
thomasleese
force-pushed
the
email-change-reset
branch
from
2d4ff64 to
700b204
Compare
|
Review app deployed to https://apply-for-qts-review-2243-web.test.teacherservices.cloud/personas |
When we change the email address associated with a work reference we'd like to treat it as though it's been re-requested, to avoid any issues where it may expire immediately after changing the email address.
thomasleese
force-pushed
the
email-change-reset
branch
from
700b204 to
dda436c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
UpdateWorkHistoryContactservice to re-request the reference request (if there is one) so the expiration date is shifted by 6 weeks, allowing the new contact enough time to respond to the reference.