[1812] Enable Logit on non-prod environments #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
force-pushed
the
1812-onboard-services-to-logitio
branch
from
68cd48c to
c7f5939
Compare
|
Review app deployed to https://apply-for-qts-review-2234-web.test.teacherservices.cloud/personas |
thomasleese
reviewed
May 31, 2024
terraform/application/variables.tf
Outdated
| @@ -74,3 +74,8 @@ variable "uploads_storage_account_name" { | |||
| type = string | |||
| default = null | |||
| } | |||
|
|
|||
| variable "enable_logit" { | |||
There was a problem hiding this comment.
Could we keep the variables in this file in alphabetical order, just to make them easier to find, and same for the tfvars files.
RMcVelia
force-pushed
the
1812-onboard-services-to-logitio
branch
from
c7f5939 to
4431860
Compare
RMcVelia
force-pushed
the
1812-onboard-services-to-logitio
branch
from
4431860 to
a1ecc20
Compare
thomasleese
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ship web and worker application logs to Logit.io. Enabled for non-prod environments first
Guidance to review
Check review app logs are in Logit and decoded correctly