Disable assessment forms after assessment #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://apply-for-qts-review-2132-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
f3643d0 to
5e711c5
Compare
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
5e711c5 to
734adf2
Compare
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
734adf2 to
b0e555e
Compare
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
b0e555e to
1404cb4
Compare
This renames a few of the methods to make them clearer.
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
1404cb4 to
ac61ed2
Compare
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
ac61ed2 to
53c768d
Compare
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
53c768d to
29085a8
Compare
When a recommendation has been made by an assessor we should disable the forms to prevent them being modified after an assessment has been made.
thomasleese
force-pushed
the
disallow-assessment-after-fi
branch
from
29085a8 to
f890c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a recommendation has been made by an assessor we should disable the forms to prevent them being modified after an assessment has been made. This is being made as we found that sometimes assessors were making changes after making a recommendation and expecting it to update the assessment, for example request more further information.
This is related to #2114 which made this clearer in the timeline.