Add DeliverEmail #2122
Merged
Add DeliverEmail #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
deliver-emails
branch
2 times, most recently
from
4e5059a to
be47d08
Compare
This adds a service for encapsulating the logic related to sending emails and recording the emails in the timeline. This allows us to send emails in the fake data and record the correct time rather than adding the timeline event in the Sidekiq process.
thomasleese
force-pushed
the
deliver-emails
branch
from
be47d08 to
4ddb84e
Compare
|
Review app deployed to https://apply-for-qts-review-2122-web.test.teacherservices.cloud/personas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a service for encapsulating the logic related to sending emails and recording the emails in the timeline. This allows us to send emails in the fake data and record the correct time rather than adding the timeline event in the Sidekiq process.