-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reviewing consent requests #2052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
review-columns
branch
from
February 28, 2024 16:57
e5c2dbb
to
8e60d2f
Compare
This updates the assessment requirements to make it possible to award or decline after the consent requests have been verified and reviewed.
All applications will go through verification now so we need to always show the task if we're passed the unknown or FI stage.
This ensures that consent requests which are due to be reviewed are shown and visible to the assessor.
thomasleese
force-pushed
the
review-consent
branch
from
February 28, 2024 17:16
2b72769
to
9811be0
Compare
thomasleese
temporarily deployed
to
development
February 28, 2024 17:27 — with
GitHub Actions
Inactive
This makes it possible to review for an assessor to review any consent requests.
thomasleese
force-pushed
the
review-consent
branch
from
February 28, 2024 17:46
9811be0
to
e513334
Compare
thomasleese
temporarily deployed
to
development
February 28, 2024 17:46 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 28, 2024 18:54 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 28, 2024 18:57 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 28, 2024 19:05 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 28, 2024 20:34 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 28, 2024 21:47 — with
GitHub Actions
Inactive
Review app deployed to https://apply-for-qts-review-2052-web.test.teacherservices.cloud/personas |
syed87
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for assessors to review consent requests which have sent for review. See individual commits for more details.