Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use teaching_qualification_part_of_degree (part 2 of 3) #2046

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Feb 27, 2024

This changes the code to use the teaching_qualification_part_of_degree column which has been added to the application form for capturing whether the teaching qualification is part of the degree. We're moving away from using the part_of_university_degree column on the qualification as there is only one entry for this.

@thomasleese thomasleese requested a review from a team as a code owner February 27, 2024 15:40
Base automatically changed from part-of-university-degree-1 to main February 28, 2024 16:56
@thomasleese thomasleese force-pushed the part-of-university-degree-2 branch from 186af6f to bf1af8b Compare February 28, 2024 16:57
This changes the code to use the teaching_qualification_part_of_degree
column which has been added to the application form for capturing
whether the teaching qualification is part of the degree. We're moving
away from using the part_of_university_degree column on the
qualification as there is only one entry for this.
@thomasleese thomasleese force-pushed the part-of-university-degree-2 branch from bf1af8b to 1367a3f Compare February 29, 2024 11:45
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit b96e169 into main Mar 1, 2024
12 checks passed
@thomasleese thomasleese deleted the part-of-university-degree-2 branch March 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants