Refactor consent requests #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a model for representing a consent request to the applicant where we need their signed consent before we can send the documents to Ecctis.
These are being replaced by the consent requests table so we can remove these fields.
thomasleese
force-pushed
the
consent-requests
branch
2 times, most recently
from
b25bcf6 to
b7622a0
Compare
This refactors all the code related to qualification requests to use consent requests where necessary.
thomasleese
force-pushed
the
consent-requests
branch
from
b7622a0 to
b344931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the qualification requests to use a new model, consent requests, and removes the consent fields from the qualification requests. This should make the code easier to understand, and allows us to use the shared requestable services and timeline events for consent requests rather than needing to duplicate the logic each time.