-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decline email content update #1955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Jan 29, 2024
Review app deployed to https://apply-for-qts-review-1955-web.test.teacherservices.cloud/personas |
thomasleese
reviewed
Jan 29, 2024
app/views/teacher_interface/application_forms/show/_declined.html.erb
Outdated
Show resolved
Hide resolved
app/views/teacher_interface/application_forms/show/_declined.html.erb
Outdated
Show resolved
Hide resolved
thomasleese
previously approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
syed87
commented
Jan 31, 2024
thomasleese
reviewed
Feb 1, 2024
thomasleese
dismissed
their stale review
February 1, 2024 13:45
Code has changed since the original approval.
syed87
force-pushed
the
AQTS-82-Content-shown-to-applicant-on-decline
branch
from
February 7, 2024 08:06
5a99321
to
ee7874b
Compare
thomasleese
reviewed
Feb 14, 2024
app/views/teacher_interface/application_forms/show/_declined.html.erb
Outdated
Show resolved
Hide resolved
app/views/teacher_interface/application_forms/show/_declined.html.erb
Outdated
Show resolved
Hide resolved
thomasleese
reviewed
Feb 14, 2024
app/views/teacher_interface/application_forms/show/_declined.html.erb
Outdated
Show resolved
Hide resolved
app/views/teacher_interface/application_forms/show/_declined.html.erb
Outdated
Show resolved
Hide resolved
thomasleese
approved these changes
Feb 15, 2024
syed87
force-pushed
the
AQTS-82-Content-shown-to-applicant-on-decline
branch
from
February 22, 2024 10:02
76133c4
to
40976f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content updates to decline email and sign in page
https://dfedigital.atlassian.net/jira/software/projects/AQTS/boards/207?selectedIssue=AQTS-82