Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop calculating work history after award/decline #1933

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

thomasleese
Copy link
Contributor

When an application is awarded or declined, and the work history is marked as ongoing, we stop counting the number of months when the application is awarded or declined to ensure the number doesn't keep increasing.

@thomasleese thomasleese requested a review from a team as a code owner January 18, 2024 13:46
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link

@thomasleese thomasleese force-pushed the work-history-end-date branch from 3676336 to 1e8c1c6 Compare January 29, 2024 17:22
@thomasleese thomasleese force-pushed the work-history-end-date branch from 1e8c1c6 to c2c9d2d Compare January 31, 2024 08:40
@thomasleese thomasleese force-pushed the work-history-end-date branch from c2c9d2d to d89f3fe Compare February 5, 2024 13:54
@thomasleese thomasleese force-pushed the work-history-end-date branch from d89f3fe to 8db3443 Compare February 7, 2024 13:48
@thomasleese thomasleese force-pushed the work-history-end-date branch from ea9d1ab to 6fbfa42 Compare February 19, 2024 14:26
@thomasleese thomasleese force-pushed the work-history-end-date branch from 6fbfa42 to fb7ea63 Compare February 19, 2024 16:31
@thomasleese thomasleese force-pushed the work-history-end-date branch from fb7ea63 to 54a399d Compare February 20, 2024 16:20
@thomasleese thomasleese force-pushed the work-history-end-date branch from 54a399d to 33f9b8a Compare February 21, 2024 12:38
@thomasleese thomasleese force-pushed the work-history-end-date branch from 33f9b8a to 81e37c3 Compare February 22, 2024 09:54
@thomasleese thomasleese force-pushed the work-history-end-date branch from 81e37c3 to 15b165f Compare February 27, 2024 07:47
@thomasleese thomasleese force-pushed the work-history-end-date branch from 15b165f to d774218 Compare February 27, 2024 13:28
When an application is awarded or declined, and the work history is
marked as ongoing, we stop counting the number of months when the
application is awarded or declined to ensure the number doesn't keep
increasing.
@thomasleese thomasleese force-pushed the work-history-end-date branch from d774218 to 6c0b655 Compare March 1, 2024 10:49
@thomasleese thomasleese merged commit 316b61a into main Mar 4, 2024
12 checks passed
@thomasleese thomasleese deleted the work-history-end-date branch March 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants