-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop calculating work history after award/decline #1933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed87
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
thomasleese
force-pushed
the
work-history-end-date
branch
6 times, most recently
from
January 25, 2024 09:44
7202f16
to
3676336
Compare
thomasleese
temporarily deployed
to
development
January 29, 2024 14:11 — with
GitHub Actions
Inactive
Review app deployed to https://apply-for-qts-review-1933-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
work-history-end-date
branch
from
January 29, 2024 17:22
3676336
to
1e8c1c6
Compare
thomasleese
temporarily deployed
to
development
January 29, 2024 17:23 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
January 31, 2024 08:40
1e8c1c6
to
c2c9d2d
Compare
thomasleese
temporarily deployed
to
development
January 31, 2024 08:40 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 5, 2024 13:54
c2c9d2d
to
d89f3fe
Compare
thomasleese
temporarily deployed
to
development
February 5, 2024 13:54 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 7, 2024 13:48
d89f3fe
to
8db3443
Compare
thomasleese
temporarily deployed
to
development
February 7, 2024 13:48 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 7, 2024 14:20 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 7, 2024 14:37 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 7, 2024 14:42 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 7, 2024 14:46 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 19, 2024 14:26
ea9d1ab
to
6fbfa42
Compare
thomasleese
temporarily deployed
to
development
February 19, 2024 14:26 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 19, 2024 16:31
6fbfa42
to
fb7ea63
Compare
thomasleese
temporarily deployed
to
development
February 19, 2024 16:31 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 20, 2024 16:20
fb7ea63
to
54a399d
Compare
thomasleese
temporarily deployed
to
development
February 20, 2024 16:20 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 20, 2024 16:40 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 21, 2024 12:38
54a399d
to
33f9b8a
Compare
thomasleese
temporarily deployed
to
development
February 21, 2024 12:38 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 22, 2024 09:54
33f9b8a
to
81e37c3
Compare
thomasleese
temporarily deployed
to
development
February 22, 2024 09:54 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 27, 2024 07:47
81e37c3
to
15b165f
Compare
thomasleese
temporarily deployed
to
development
February 27, 2024 07:47 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
February 27, 2024 07:58 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
work-history-end-date
branch
from
February 27, 2024 13:28
15b165f
to
d774218
Compare
thomasleese
temporarily deployed
to
development
February 27, 2024 13:28 — with
GitHub Actions
Inactive
When an application is awarded or declined, and the work history is marked as ongoing, we stop counting the number of months when the application is awarded or declined to ensure the number doesn't keep increasing.
thomasleese
force-pushed
the
work-history-end-date
branch
from
March 1, 2024 10:49
d774218
to
6c0b655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application is awarded or declined, and the work history is marked as ongoing, we stop counting the number of months when the application is awarded or declined to ensure the number doesn't keep increasing.