Improve example data generation #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
|
Review app deployed to https://apply-for-qts-review-1918-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
improve-personas
branch
from
fb6b42b to
2fe5013
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
This uses Faker to generate some approriate example data so it looks more realistic.
This makes the dates more dynamic and therefore more varied.
This updates the factories for work history and qualifications to ensure there is more than one work history so it's more realistic.
thomasleese
force-pushed
the
improve-personas
branch
from
2fe5013 to
39b1eb7
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the example data that we generate for work history and qualifications to make it more realistic and make it easier for product and design reviews.