Refactor assessor policies #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
This was referenced Dec 7, 2023
thomasleese
force-pushed
the
refactor-policies
branch
from
aa941af to
67a35a5
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
|
Review app deployed to https://apply-for-qts-review-1855-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
refactor-policies
branch
from
67a35a5 to
9d403a4
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
refactor-policies
branch
from
9d403a4 to
0a17ed7
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
refactor-policies
branch
from
0a17ed7 to
4fb9198
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
This fixes the name of the shared example so it reads better.
This adds more methods to the policy to match the controller.
This improves the code by reducing duplication.
This adds a new policy for assessment sections.
This uses the new shared examples and reduces duplication in the code.
This adds a policy for the assessor and reviewer assignment controllers.
This captures the logic related to the further information controller.
This makes it specific to the controller as it was only used in one place.
This uses the new shared examples.
This refactors how we handle permissions for qualification requests in preparation for the new verification journey.
This adds a new policy for verifying reference requests.
This has been moved in to the assessment controller and uses the same policy.
This has been moved in to the application form controller and uses the same policy.
To use the application form policy.
This uses the shared examples in the tests.
It's no longer used anywhere.
thomasleese
force-pushed
the
refactor-policies
branch
from
4fb9198 to
e66a385
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the policies used in the assessor interface to have bespoke policies for each kind of controller/model allowing better flexibility as we've got more permissions now and as we build the new verification journeys.