Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set app_replicas to 2 for aks production #1847

Closed
wants to merge 1 commit into from
Closed

Set app_replicas to 2 for aks production #1847

wants to merge 1 commit into from

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Dec 6, 2023

No description provided.

@johnake johnake requested a review from a team as a code owner December 6, 2023 12:06
@johnake johnake force-pushed the 811-increase-apply-for-qts-replicas branch from b8fb2da to 4bcc5e0 Compare December 6, 2023 12:14
thomasleese
thomasleese reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I've just left a few comments on the style. Could we also add a description to the commit explaining why we're making this change?

terraform/application/variables.tf Outdated Show resolved Hide resolved
terraform/application/config/production/variables.tfvars.json Outdated Show resolved Hide resolved
@johnake johnake force-pushed the 811-increase-apply-for-qts-replicas branch from 4bcc5e0 to 821ded6 Compare December 6, 2023 13:05
@johnake johnake force-pushed the 811-increase-apply-for-qts-replicas branch from 821ded6 to 0ded3cb Compare December 6, 2023 13:34
@johnake johnake closed this Dec 6, 2023
@thomasleese thomasleese deleted the 811-increase-apply-for-qts-replicas branch December 14, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasleese thomasleese thomasleese left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnake @thomasleese