Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make teaching qualification duration optional #1845

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Dec 5, 2023

We want to do some final calculations on this so we need to bring back the ability to set this to false. This will be reverted once we've done the analysis.

Jira Issue

We want to do some final calculations on this so we need to bring back
the ability to set this to false. This will be reverted once we've done
the analysis.
@thomasleese thomasleese requested a review from a team as a code owner December 5, 2023 14:27
@thomasleese thomasleese enabled auto-merge December 5, 2023 14:27
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit 3c7cd88 into main Dec 5, 2023
12 checks passed
@thomasleese thomasleese deleted the optional-teaching-qualification branch December 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants