Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content changes #1775

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Content changes #1775

merged 4 commits into from
Nov 2, 2023

Conversation

syed87
Copy link
Contributor

@syed87 syed87 commented Oct 30, 2023

6 Content changes made the details are in the ticket below

https://trello.com/c/82nfMggn/2352-content-changes-ticket

  1. Request LoPS Verification Page Text Update
  2. Typo on Verify LoPS Page
  3. Typos on Request LoPS Verification Page
  4. Color of Review Tag
  5. Admin Journey - Task Status: Accepting LoPS
  6. Errors on the ‘review verifications’ screen:

@syed87 syed87 requested a review from a team as a code owner October 30, 2023 11:07
@richardpattinson richardpattinson changed the base branch from main to verification-lops November 1, 2023 12:35
thomasleese
thomasleese reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments, but looks good. Once this is merged in to verification-lops I'll squash it in to the commits there.

app/views/assessor_interface/review_verifications/index.html.erb Outdated Show resolved Hide resolved
app/views/assessor_interface/professional_standing_requests/show.html.erb Outdated Show resolved Hide resolved
@thomasleese thomasleese force-pushed the verification-lops branch 2 times, most recently from 6f6fcf2 to 47aa9e4 Compare November 2, 2023 13:07
@syed87 syed87 merged commit 05ad15a into verification-lops Nov 2, 2023
3 checks passed
@syed87 syed87 deleted the content-changes branch November 2, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasleese thomasleese thomasleese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syed87 @thomasleese