Remove ready for review field

app/controllers/assessor_interface/professional_standing_requests_controller.rb

@@ -18,7 +18,6 @@ def edit_locate
           requestable:,
           user: current_staff,
           received: requestable.received?,
-          ready_for_review: requestable.ready_for_review,
           location_note: requestable.location_note,
         )
     end
@@ -170,7 +169,7 @@ def set_variables
     def location_form_params
       params.require(
         :assessor_interface_professional_standing_request_location_form,
-      ).permit(:received, :ready_for_review, :location_note)
+      ).permit(:received, :location_note)
     end
 
     def review_form_params

app/forms/assessor_interface/professional_standing_request_location_form.rb

@@ -10,9 +10,6 @@ class AssessorInterface::ProfessionalStandingRequestLocationForm
   attribute :received, :boolean
   validates :received, inclusion: [true, false]
 
-  attribute :ready_for_review, :boolean
-  validates :ready_for_review, inclusion: [true, false], unless: :received
-
   attribute :location_note, :string
 
   def save
@@ -30,10 +27,7 @@ def save
         ApplicationFormStatusUpdater.call(application_form:, user:)
       end
 
-      requestable.update!(
-        location_note: location_note.presence || "",
-        ready_for_review: ready_for_review || false,
-      )
+      requestable.update!(location_note: location_note.presence || "")
     end
 
     true

app/models/professional_standing_request.rb

@@ -4,21 +4,20 @@
 #
 # Table name: professional_standing_requests
 #
-#  id               :bigint           not null, primary key
-#  expired_at       :datetime
-#  location_note    :text             default(""), not null
-#  ready_for_review :boolean          default(FALSE), not null
-#  received_at      :datetime
-#  requested_at     :datetime
-#  review_note      :string           default(""), not null
-#  review_passed    :boolean
-#  reviewed_at      :datetime
-#  verified_at      :datetime
-#  verify_note      :text             default(""), not null
-#  verify_passed    :boolean
-#  created_at       :datetime         not null
-#  updated_at       :datetime         not null
-#  assessment_id    :bigint           not null
+#  id            :bigint           not null, primary key
+#  expired_at    :datetime
+#  location_note :text             default(""), not null
+#  received_at   :datetime
+#  requested_at  :datetime
+#  review_note   :string           default(""), not null
+#  review_passed :boolean
+#  reviewed_at   :datetime
+#  verified_at   :datetime
+#  verify_note   :text             default(""), not null
+#  verify_passed :boolean
+#  created_at    :datetime         not null
+#  updated_at    :datetime         not null
+#  assessment_id :bigint           not null
 #
 # Indexes
 #

config/analytics.yml

@@ -218,7 +218,6 @@
     - expired_at
     - id
     - location_note
-    - ready_for_review
     - received_at
     - requested_at
     - review_note

db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb

@@ -0,0 +1,11 @@
+class RemoveReadyForReviewFromProfessionalStandingRequests < ActiveRecord::Migration[
+  7.1
+]
+  def change
+    remove_column :professional_standing_requests,
+                  :ready_for_review,
+                  :boolean,
+                  null: false,
+                  default: false
+  end
+end

spec/factories/professional_standing_requests.rb

@@ -4,21 +4,20 @@
 #
 # Table name: professional_standing_requests
 #
-#  id               :bigint           not null, primary key
-#  expired_at       :datetime
-#  location_note    :text             default(""), not null
-#  ready_for_review :boolean          default(FALSE), not null
-#  received_at      :datetime
-#  requested_at     :datetime
-#  review_note      :string           default(""), not null
-#  review_passed    :boolean
-#  reviewed_at      :datetime
-#  verified_at      :datetime
-#  verify_note      :text             default(""), not null
-#  verify_passed    :boolean
-#  created_at       :datetime         not null
-#  updated_at       :datetime         not null
-#  assessment_id    :bigint           not null
+#  id            :bigint           not null, primary key
+#  expired_at    :datetime
+#  location_note :text             default(""), not null
+#  received_at   :datetime
+#  requested_at  :datetime
+#  review_note   :string           default(""), not null
+#  review_passed :boolean
+#  reviewed_at   :datetime
+#  verified_at   :datetime
+#  verify_note   :text             default(""), not null
+#  verify_passed :boolean
+#  created_at    :datetime         not null
+#  updated_at    :datetime         not null
+#  assessment_id :bigint           not null
 #
 # Indexes
 #

spec/forms/assessor_interface/professional_standing_request_location_form_spec.rb

@@ -8,30 +8,16 @@
   let(:user) { create(:staff) }
 
   let(:received) { "" }
-  let(:ready_for_review) { "" }
   let(:location_note) { "" }
 
   subject(:form) do
-    described_class.new(
-      requestable:,
-      user:,
-      received:,
-      ready_for_review:,
-      location_note:,
-    )
+    described_class.new(requestable:, user:, received:, location_note:)
   end
 
   describe "validations" do
     it { is_expected.to validate_presence_of(:requestable) }
     it { is_expected.to validate_presence_of(:user) }
     it { is_expected.to allow_values(true, false).for(:received) }
-    it { is_expected.to allow_values(true, false).for(:ready_for_review) }
-
-    context "when not received" do
-      let(:received) { "false" }
-
-      it { is_expected.to_not allow_values(nil).for(:ready_for_review) }
-    end
   end
 
   describe "#save" do
@@ -60,26 +46,10 @@
       end
     end
 
-    context "when not received and ready for review" do
-      let(:received) { "false" }
-      let(:ready_for_review) { "true" }
-
-      it { is_expected.to be true }
-
-      it "sets ready for review" do
-        expect { save }.to change(requestable, :ready_for_review).to(true)
-      end
-    end
-
-    context "when not received and not ready for review" do
+    context "when not received" do
       let(:received) { "false" }
-      let(:ready_for_review) { "false" }
 
       it { is_expected.to be true }
-
-      it "doesn't set ready for review" do
-        expect { save }.to_not change(requestable, :ready_for_review)
-      end
     end
   end
 end

spec/models/professional_standing_request_spec.rb

@@ -4,21 +4,20 @@
 #
 # Table name: professional_standing_requests
 #
-#  id               :bigint           not null, primary key
-#  expired_at       :datetime
-#  location_note    :text             default(""), not null
-#  ready_for_review :boolean          default(FALSE), not null
-#  received_at      :datetime
-#  requested_at     :datetime
-#  review_note      :string           default(""), not null
-#  review_passed    :boolean
-#  reviewed_at      :datetime
-#  verified_at      :datetime
-#  verify_note      :text             default(""), not null
-#  verify_passed    :boolean
-#  created_at       :datetime         not null
-#  updated_at       :datetime         not null
-#  assessment_id    :bigint           not null
+#  id            :bigint           not null, primary key
+#  expired_at    :datetime
+#  location_note :text             default(""), not null
+#  received_at   :datetime
+#  requested_at  :datetime
+#  review_note   :string           default(""), not null
+#  review_passed :boolean
+#  reviewed_at   :datetime
+#  verified_at   :datetime
+#  verify_note   :text             default(""), not null
+#  verify_passed :boolean
+#  created_at    :datetime         not null
+#  updated_at    :datetime         not null
+#  assessment_id :bigint           not null
 #
 # Indexes
 #