Add review verifications task #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
review-verifications
branch
from
695aa37 to
7fdb4d7
Compare
We're going to rename this to verify as this will become the page that admins use to verify the professional standing request, and the review controller methods will become the page that assessors use.
It's deprecated as a boolean value.
This adds a controller for handling the review verifications task where an assessor will review any verification requests which an admin couldn't verify themselves.
This adds the controller methods to support the functionality to allow an assessor to review any professional standing requests which couldn't be verified.
This allows us to award or decline an application after the review process, rather than only after the verification process.
This adds a system test for the review verifications journey to ensure that it works as expected.
thomasleese
force-pushed
the
review-verifications
branch
from
7fdb4d7 to
e640b77
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the journey for reviewing verifications which works in combination with #1743 and #1744. I haven't added any tests yet, but they will be added later in a subsequent PR.
Trello Card
Screenshots