2262 add verification permission #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Sep 29, 2023
db/migrate/20230929084821_add_verification_permission_to_staff_users.rb
Outdated
Show resolved
Hide resolved
richardpattinson
force-pushed
the
2262-add-verification-permission
branch
5 times, most recently
from
b1d6284 to
09c2b62
Compare
thomasleese
reviewed
Sep 29, 2023
richardpattinson
force-pushed
the
2262-add-verification-permission
branch
from
09c2b62 to
a719315
Compare
thomasleese
reviewed
Sep 29, 2023
app/views/personas/index.html.erb
Outdated
| colgroup.with_col(span: 1) | ||
| end | ||
|
|
||
| table.with_head do |head| | ||
| head.with_row do |row| | ||
| row.with_cell(scope: false) | ||
| row.with_cell(header: true, text: "Permissions", colspan: 5) | ||
| row.with_cell(header: true, text: "Permissions", colspan: 6) |
There was a problem hiding this comment.
Suggested change
| row.with_cell(header: true, text: "Permissions", colspan: 6) | |
| row.with_cell(header: true, text: "Permissions", colspan: 7) |
I actually think this needs to be 7 because there are 7 permission columns (I think the value of 5 before was incorrect).
richardpattinson
force-pushed
the
2262-add-verification-permission
branch
2 times, most recently
from
d4a1db7 to
39a9742
Compare
richardpattinson
force-pushed
the
2262-add-verification-permission
branch
from
39a9742 to
bdcf71d
Compare
thomasleese
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a new permission for staff users which captures whether they’ve got access to do new verification journey.
Added a migration to store the new permission on the staff model, and update the support console/example data to support this new permission.