Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoPS verification journey #1722

Merged
merged 13 commits into from
Nov 8, 2023
Merged

LoPS verification journey #1722

merged 13 commits into from
Nov 8, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 27, 2023

This allows an assessors to mark the LoPS verification to be done, and updates the task list to match the new design with a single entry which takes the user to a separate page.

Trello Card

Screenshots

Screenshot 2023-10-05 at 11 19 12
Screenshot 2023-10-05 at 11 19 25
Screenshot 2023-10-10 at 10 16 48
Screenshot 2023-10-10 at 11 35 32
Screenshot 2023-10-10 at 11 35 37
Screenshot 2023-10-10 at 15 10 27
Screenshot 2023-10-10 at 15 10 31

@thomasleese thomasleese force-pushed the verification-lops branch 13 times, most recently from eaf6d37 to 5d89c40 Compare October 4, 2023 11:21
@thomasleese thomasleese temporarily deployed to development October 4, 2023 14:45 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development October 4, 2023 15:14 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development October 4, 2023 15:59 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review October 4, 2023 16:19 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@thomasleese thomasleese temporarily deployed to development October 5, 2023 08:49 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review October 5, 2023 09:10 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development October 5, 2023 10:38 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review October 5, 2023 10:55 — with GitHub Actions Inactive
thomasleese and others added 8 commits November 8, 2023 13:31
Since there's no contact page we don't need to prefix this page with
`verify`.
This updates the content on the page where we ask assessors whether
they'd like to verify the LoPS.
This updates the task list item that assessors and admins see when they
need to verify the LoPS.
This ensures that we are marking the requestable as having been received
if we're verifying it.
This adds the views and controller actions to implement the new "Verify
LoPS" page according to the new designs of the verification journey.

Co-authored-by: Shujat Khalid <[email protected]>
This ensures that admins are marked as the action required by user type
when the LoPS has been marked as received, or is overdue.
This replaces the existing view which admins use with the newer LoPS
response page.
This makes it possible to send an assessment to review if the LoPS is
unable to be verified by an admin user.
thomasleese and others added 3 commits November 8, 2023 13:50
This updates the system tests for verifying LoPS to use the newer verify
page and updates to use the right permissions.
We only want the indentation with a section title as it lines up with
the number of the section.
If the admin decides that the LoPS is not acceptable, and they'd like to
send this to review, we've decided to split this in to two pages so the
internal notes appears on its own page.
@thomasleese thomasleese merged commit c5b6905 into main Nov 8, 2023
12 checks passed
@thomasleese thomasleese deleted the verification-lops branch November 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants