-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoPS verification journey #1722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
verification-lops
branch
13 times, most recently
from
October 4, 2023 11:21
eaf6d37
to
5d89c40
Compare
thomasleese
temporarily deployed
to
development
October 4, 2023 14:45 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
October 4, 2023 15:14
5d89c40
to
c7cf041
Compare
thomasleese
temporarily deployed
to
development
October 4, 2023 15:14 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
October 4, 2023 15:59
c7cf041
to
a1e86be
Compare
thomasleese
temporarily deployed
to
development
October 4, 2023 15:59 — with
GitHub Actions
Inactive
Review app deployed to https://apply-for-qts-review-1722-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
verification-lops
branch
from
October 5, 2023 08:49
a1e86be
to
aeb9123
Compare
thomasleese
temporarily deployed
to
development
October 5, 2023 08:49 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
October 5, 2023 10:38
aeb9123
to
bb4a22a
Compare
thomasleese
temporarily deployed
to
development
October 5, 2023 10:38 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
October 5, 2023 11:57
bb4a22a
to
0d34293
Compare
thomasleese
force-pushed
the
verification-lops
branch
from
November 7, 2023 17:14
72038e9
to
a136262
Compare
thomasleese
temporarily deployed
to
development
November 7, 2023 17:14 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
November 8, 2023 09:04
a136262
to
aeb179b
Compare
thomasleese
temporarily deployed
to
development
November 8, 2023 09:04 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
November 8, 2023 13:09
aeb179b
to
7b9ea5d
Compare
thomasleese
temporarily deployed
to
development
November 8, 2023 13:09 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
verification-lops
branch
from
November 8, 2023 13:26
7b9ea5d
to
3cf63c3
Compare
thomasleese
temporarily deployed
to
development
November 8, 2023 13:26 — with
GitHub Actions
Inactive
Since there's no contact page we don't need to prefix this page with `verify`.
This updates the content on the page where we ask assessors whether they'd like to verify the LoPS.
This updates the task list item that assessors and admins see when they need to verify the LoPS.
This ensures that we are marking the requestable as having been received if we're verifying it.
This adds the views and controller actions to implement the new "Verify LoPS" page according to the new designs of the verification journey. Co-authored-by: Shujat Khalid <[email protected]>
This ensures that admins are marked as the action required by user type when the LoPS has been marked as received, or is overdue.
This replaces the existing view which admins use with the newer LoPS response page.
This makes it possible to send an assessment to review if the LoPS is unable to be verified by an admin user.
thomasleese
force-pushed
the
verification-lops
branch
from
November 8, 2023 13:33
3cf63c3
to
7b679a7
Compare
thomasleese
temporarily deployed
to
development
November 8, 2023 13:34 — with
GitHub Actions
Inactive
This updates the system tests for verifying LoPS to use the newer verify page and updates to use the right permissions.
We only want the indentation with a section title as it lines up with the number of the section.
If the admin decides that the LoPS is not acceptable, and they'd like to send this to review, we've decided to split this in to two pages so the internal notes appears on its own page.
thomasleese
force-pushed
the
verification-lops
branch
from
November 8, 2023 13:52
7b679a7
to
59ae8b7
Compare
thomasleese
temporarily deployed
to
development
November 8, 2023 13:52 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an assessors to mark the LoPS verification to be done, and updates the task list to match the new design with a single entry which takes the user to a separate page.
Trello Card
Screenshots