Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename state_changed to status_changed #1715

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 24, 2023

We're going to rename this to status_changed to better represent how we show it to users.

Depends on #1708

Trello Card

@thomasleese thomasleese force-pushed the rename-state-changed-to-status-changed branch from a16607c to d99f30d Compare September 27, 2023 11:54
@thomasleese thomasleese marked this pull request as ready for review September 27, 2023 11:54
@thomasleese thomasleese requested a review from a team as a code owner September 27, 2023 11:54
@thomasleese thomasleese force-pushed the rename-state-changed-to-status-changed branch 4 times, most recently from 203868e to 83b8cf8 Compare September 27, 2023 16:24
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

We're going to rename this to `status_changed` to better represent how
we show it to users.
We're going to rename the `state_changed` event type to
`status_changed`.
@thomasleese thomasleese force-pushed the rename-state-changed-to-status-changed branch from 83b8cf8 to 6e971e3 Compare September 27, 2023 17:20
@thomasleese thomasleese merged commit a4adeb8 into main Sep 27, 2023
12 checks passed
@thomasleese thomasleese deleted the rename-state-changed-to-status-changed branch September 27, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants