Remove old_state and new_state

app/components/timeline_entry/component.rb

@@ -46,16 +46,14 @@ def status_changed_vars
         old_status:
           render(
             StatusTag::Component.new(
-              status:
-                timeline_event.old_state.presence || timeline_event.old_value,
+              status: timeline_event.old_value,
               class_context: "timeline-event",
             ),
           ).strip,
         new_status:
           render(
             StatusTag::Component.new(
-              status:
-                timeline_event.new_state.presence || timeline_event.new_value,
+              status: timeline_event.new_value,
               class_context: "timeline-event",
             ),
           ).strip,

app/models/timeline_event.rb

@@ -15,9 +15,7 @@
 #  mailer_action_name    :string           default(""), not null
 #  mailer_class_name     :string           default(""), not null
 #  message_subject       :string           default(""), not null
-#  new_state             :string           default(""), not null
 #  new_value             :text             default(""), not null
-#  old_state             :string           default(""), not null
 #  old_value             :text             default(""), not null
 #  requestable_type      :string
 #  subjects              :text             default([]), not null, is an Array

config/analytics.yml

@@ -389,10 +389,8 @@
     - mailer_action_name
     - mailer_class_name
     - message_subject
-    - new_state
     - new_value
     - note_id
-    - old_state
     - old_value
     - requestable_id
     - requestable_type

db/migrate/20230920152618_remove_state_from_timeline_events.rb

@@ -0,0 +1,8 @@
+class RemoveStateFromTimelineEvents < ActiveRecord::Migration[7.0]
+  def change
+    change_table :timeline_events, bulk: true do |t|
+      t.remove :old_state, type: :string, default: "", null: false
+      t.remove :new_state, type: :string, default: "", null: false
+    end
+  end
+end

spec/factories/timeline_events.rb

@@ -13,9 +13,7 @@
 #  mailer_action_name    :string           default(""), not null
 #  mailer_class_name     :string           default(""), not null
 #  message_subject       :string           default(""), not null
-#  new_state             :string           default(""), not null
 #  new_value             :text             default(""), not null
-#  old_state             :string           default(""), not null
 #  old_value             :text             default(""), not null
 #  requestable_type      :string
 #  subjects              :text             default([]), not null, is an Array

spec/models/timeline_event_spec.rb

@@ -13,9 +13,7 @@
 #  mailer_action_name    :string           default(""), not null
 #  mailer_class_name     :string           default(""), not null
 #  message_subject       :string           default(""), not null
-#  new_state             :string           default(""), not null
 #  new_value             :text             default(""), not null
-#  old_state             :string           default(""), not null
 #  old_value             :text             default(""), not null
 #  requestable_type      :string
 #  subjects              :text             default([]), not null, is an Array