Stop using old_state and new_state #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
use-old-value-new-value
branch
5 times, most recently
from
b2e9faf to
a18ca9c
Compare
thomasleese
force-pushed
the
use-old-value-new-value
branch
4 times, most recently
from
d14301a to
8403562
Compare
thomasleese
changed the title
thomasleese
force-pushed
the
use-old-value-new-value
branch
from
8403562 to
0443427
Compare
We're going to replace them with old_value/new_value so we can stop using them.
thomasleese
force-pushed
the
use-old-value-new-value
branch
from
0443427 to
7ff07e3
Compare
Since we're going to stop using the old_state and new_state fields and instead rely on the existing old_value and new_value fields.
thomasleese
force-pushed
the
use-old-value-new-value
branch
from
7ff07e3 to
04da91b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to replace them with
old_valueandnew_valueto reduce the number of fields on the timeline event model.Depends on #1703
Trello Card