Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using old application form status fields #1702

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 19, 2023

This updates various parts of the system to stop using the status (and related) fields, as they've been replaced by others.

Depends on #1698

Trello Card

@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 4 times, most recently from 7f11901 to 9180a46 Compare September 24, 2023 13:05
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 9 times, most recently from 55363f1 to d79fc8d Compare October 4, 2023 11:35
@thomasleese thomasleese marked this pull request as ready for review October 4, 2023 11:36
@thomasleese thomasleese requested a review from a team as a code owner October 4, 2023 11:36
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 13 times, most recently from c53daae to e35e734 Compare October 11, 2023 12:42
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 3 times, most recently from 0df4277 to 232e073 Compare October 16, 2023 15:29
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 3 times, most recently from 0523fe5 to f61c650 Compare November 8, 2023 18:32
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 6 times, most recently from 54f4518 to 55dec63 Compare November 10, 2023 17:27
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch 3 times, most recently from 4406204 to 8d06a0d Compare November 17, 2023 07:42
This reorders the methods to make it clearer where they're used.
This updates the ApplicationFormStatusUpdater service to stop updating
the status (and related fields) as we're going to stop using them and
instead rely on the replacements.
This updates various parts of the system to stop using the status (and
related) fields, as they've been replaced by others.
@thomasleese thomasleese force-pushed the stop-using-application-form-status branch from 8d06a0d to 263e9c4 Compare November 21, 2023 09:47
@thomasleese thomasleese merged commit 09de651 into main Nov 21, 2023
12 checks passed
@thomasleese thomasleese deleted the stop-using-application-form-status branch November 21, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants