Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide additional fields for countries with one region #1669

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

thomasleese
Copy link
Contributor

At the moment with countries with on region there are two places you can put this information, which is confusing. Instead we should hide it to encourage users to use the region.

I've also made a few changes to the pages to organise the fields and better match the designs.

Trello Card

This moves around various fields to better match the design.
@thomasleese thomasleese requested a review from a team as a code owner September 8, 2023 10:27
@thomasleese thomasleese temporarily deployed to development September 8, 2023 10:27 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development September 8, 2023 10:27 — with GitHub Actions Inactive
At the moment with countryies with on region there are two places you
can put this information, which is confusing. Instead we should hide it
to encourage users to use the region.
@thomasleese thomasleese force-pushed the hide-country-information branch from b3c49f9 to 99ed197 Compare September 8, 2023 10:48
@thomasleese thomasleese temporarily deployed to development September 8, 2023 10:48 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review September 8, 2023 10:59 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit d01077c into main Sep 11, 2023
@thomasleese thomasleese deleted the hide-country-information branch September 11, 2023 07:09
@thomasleese thomasleese temporarily deployed to review September 11, 2023 07:10 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants