Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preliminary check from country #1664

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

thomasleese
Copy link
Contributor

This removes the fields from countries and leaves it on regions, it should make the support console simpler and remove any confusion about where to set this.

Trello card

@thomasleese thomasleese requested a review from a team as a code owner September 5, 2023 12:42
@thomasleese thomasleese temporarily deployed to development September 5, 2023 12:42 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development September 5, 2023 12:42 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development September 5, 2023 12:59 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review September 5, 2023 13:12 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This removes the column from the country model as we want to stop having
values captured in two places, so instead we'll leave it on the region
model.
This column has ben removed from the countries so we need to remove
any references to it.
@thomasleese thomasleese force-pushed the remove-preliminary-check-from-country branch from 6694260 to 8c9b4c5 Compare September 7, 2023 06:33
@thomasleese thomasleese temporarily deployed to development September 7, 2023 06:33 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review September 7, 2023 06:47 — with GitHub Actions Inactive
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit d6c03e4 into main Sep 7, 2023
12 checks passed
@thomasleese thomasleese deleted the remove-preliminary-check-from-country branch September 7, 2023 10:28
@thomasleese thomasleese temporarily deployed to review September 7, 2023 10:28 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants