Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove teaching authority fields from countries #1661

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 4, 2023

This removes the teaching authority contact information from countries, as we've decided we'd like them instead to only be on regions, to simplify the support console and allow it to be transferred over to be managed fully by the TRA.

Trello Card

@thomasleese thomasleese temporarily deployed to development September 4, 2023 18:17 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development September 4, 2023 18:17 — with GitHub Actions Inactive
@thomasleese thomasleese marked this pull request as ready for review September 4, 2023 18:18
@thomasleese thomasleese requested a review from a team as a code owner September 4, 2023 18:18
@thomasleese thomasleese temporarily deployed to review September 4, 2023 18:38 — with GitHub Actions Inactive
@thomasleese thomasleese force-pushed the remove-country-teaching-authority branch from 833895c to 86e9491 Compare September 4, 2023 18:39
@thomasleese thomasleese temporarily deployed to development September 4, 2023 18:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

@thomasleese thomasleese temporarily deployed to review September 4, 2023 18:53 — with GitHub Actions Inactive
@thomasleese thomasleese force-pushed the remove-country-teaching-authority branch from 86e9491 to a013175 Compare September 5, 2023 09:40
@thomasleese thomasleese temporarily deployed to development September 5, 2023 09:40 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review September 5, 2023 10:01 — with GitHub Actions Inactive
@thomasleese thomasleese force-pushed the remove-country-teaching-authority branch from a013175 to 45a14fd Compare September 7, 2023 06:24
@thomasleese thomasleese temporarily deployed to development September 7, 2023 06:24 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review September 7, 2023 06:43 — with GitHub Actions Inactive
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

We're going to keep them only on regions to simplify the support
console.
@thomasleese thomasleese force-pushed the remove-country-teaching-authority branch from 45a14fd to 8d7aa8a Compare September 7, 2023 11:06
@thomasleese thomasleese temporarily deployed to development September 7, 2023 11:06 — with GitHub Actions Inactive
The teaching authority fields have been removed from countries so we can
remove the references to them in various other places.
@thomasleese thomasleese force-pushed the remove-country-teaching-authority branch from 8d7aa8a to 633fdc3 Compare September 7, 2023 11:13
@thomasleese thomasleese temporarily deployed to development September 7, 2023 11:13 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development September 7, 2023 11:45 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to development September 7, 2023 11:50 — with GitHub Actions Inactive
@thomasleese thomasleese temporarily deployed to review September 7, 2023 11:50 — with GitHub Actions Inactive
@thomasleese thomasleese merged commit 75452b9 into main Sep 7, 2023
@thomasleese thomasleese deleted the remove-country-teaching-authority branch September 7, 2023 16:00
@thomasleese thomasleese temporarily deployed to review September 7, 2023 16:00 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants