-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove teaching authority fields from countries #1661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
temporarily deployed
to
development
September 4, 2023 18:17 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
September 4, 2023 18:17 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
remove-country-teaching-authority
branch
from
September 4, 2023 18:39
833895c
to
86e9491
Compare
thomasleese
temporarily deployed
to
development
September 4, 2023 18:39 — with
GitHub Actions
Inactive
Review app deployed to https://apply-for-qts-review-1661-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
remove-country-teaching-authority
branch
from
September 5, 2023 09:40
86e9491
to
a013175
Compare
thomasleese
temporarily deployed
to
development
September 5, 2023 09:40 — with
GitHub Actions
Inactive
thomasleese
force-pushed
the
remove-country-teaching-authority
branch
from
September 7, 2023 06:24
a013175
to
45a14fd
Compare
thomasleese
temporarily deployed
to
development
September 7, 2023 06:24 — with
GitHub Actions
Inactive
syed87
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
We're going to keep them only on regions to simplify the support console.
thomasleese
force-pushed
the
remove-country-teaching-authority
branch
from
September 7, 2023 11:06
45a14fd
to
8d7aa8a
Compare
thomasleese
temporarily deployed
to
development
September 7, 2023 11:06 — with
GitHub Actions
Inactive
The teaching authority fields have been removed from countries so we can remove the references to them in various other places.
thomasleese
force-pushed
the
remove-country-teaching-authority
branch
from
September 7, 2023 11:13
8d7aa8a
to
633fdc3
Compare
thomasleese
temporarily deployed
to
development
September 7, 2023 11:13 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
September 7, 2023 11:45 — with
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
September 7, 2023 11:50 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the teaching authority contact information from countries, as we've decided we'd like them instead to only be on regions, to simplify the support console and allow it to be transferred over to be managed fully by the TRA.
Trello Card