Add change applicant name functionality #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
change-name
branch
from
e6d7f60 to
5536369
Compare
|
Review app deployed to https://apply-for-qts-review-1621-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
change-name
branch
from
5536369 to
315b1e8
Compare
thomasleese
force-pushed
the
change-name
branch
from
315b1e8 to
325c7ea
Compare
thomasleese
force-pushed
the
change-name
branch
from
325c7ea to
b8a1422
Compare
thomasleese
force-pushed
the
change-name
branch
from
b8a1422 to
e14531b
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
change-name
branch
from
e14531b to
d5e1daa
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
change-name
branch
from
d5e1daa to
25677c4
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
change-name
branch
from
25677c4 to
e40930c
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
change-name
branch
from
e40930c to
ed9c757
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
richardpattinson
approved these changes
Aug 30, 2023
thomasleese
force-pushed
the
change-name
branch
from
ed9c757 to
d6ccc3a
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
change-name
branch
from
d6ccc3a to
73af906
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
change-name
branch
from
73af906 to
4843801
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
This adds a new column to the staff table which records whether the staff user has permission to change application names.
This adds the ability to select a user with the change name permission in the personas (and makes sure that one is generated in the example data).
This allows us to invite users with that permission, and gives the ability for support users to give others that permission.
I've update the policy to allow updating or editing an application form if the user has the right permission. I've also refactored the tests to use some shared examples to reduce duplication.
This is a form which uses the new UpdateApplicationFormName service to allow assessors to change the name on an application form.
This removes an argument which was always set to true, and simplifies the actions.
This adds a link to the summary list rows if the staff user has the right permission, allowing them to change the given names and family name of the applicant.
This changes the page object to use the summary list object rather than look for the items directly.
This adds the ability for an assessor with the right permissions to change the applicant name associated with an application.
thomasleese
force-pushed
the
change-name
branch
from
4843801 to
ffcab97
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for an assessor with the right permissions to change the applicant name associated with an application.
Screenshots