Refactor status tag component

This refactors the component to accept multiple statuses and render the
tags next to each other.

app/components/status_tag/component.html.erb

@@ -1 +1,3 @@
-<%= govuk_tag(text:, colour:, html_attributes: { id: }, classes:) %>
+<% tags.each do |tag| %>
+  <%= govuk_tag(**tag) %>
+<% end %>

app/components/status_tag/component.rb

@@ -2,21 +2,24 @@
 
 module StatusTag
   class Component < ViewComponent::Base
-    def initialize(status:, id: nil, class_context: nil)
+    def initialize(statuses, id: nil, class_context: nil)
       super
-      @status = status.to_sym
+      @statuses = statuses
       @id = id
       @class_context = class_context
     end
 
-    attr_reader :id
+    attr_reader :statuses, :id, :class_context
 
-    def text
-      I18n.t(@status, scope: %i[components status_tag])
-    end
-
-    def classes
-      @class_context ? ["#{@class_context}__tag"] : []
+    def tags
+      Array(statuses).map do |status|
+        {
+          text: I18n.t(status, scope: %i[components status_tag]),
+          colour: COLOURS[status.to_sym],
+          classes: class_context ? ["#{class_context}__tag"] : [],
+          html_attributes: id ? { id: } : {},
+        }
+      end
     end
 
     COLOURS = {
@@ -54,9 +57,5 @@ def classes
       waiting_on_reference: "yellow",
       withdrawn: "red",
     }.freeze
-
-    def colour
-      COLOURS[@status]
-    end
   end
 end

app/components/task_list/component.html.erb

@@ -22,7 +22,7 @@
               <% end %>
             </span>
 
-            <%= render(StatusTag::Component.new(id: status_id, status: item[:status], class_context: "app-task-list")) %>
+            <%= render(StatusTag::Component.new(item[:status], id: status_id, class_context: "app-task-list")) %>
           </li>
         <% end %>
       </ul>

app/components/timeline_entry/component.html.erb

@@ -23,7 +23,7 @@
     <% elsif timeline_event.assessment_section_recorded? %>
       <p class="govuk-body">
         <%= description_vars[:section_name] %>:
-        <%= render StatusTag::Component.new(status: description_vars[:passed] ? "accepted" : "rejected") %>
+        <%= render StatusTag::Component.new(description_vars[:passed] ? "accepted" : "rejected") %>
       </p>
 
       <% if (visible_failure_reasons = description_vars[:visible_failure_reasons]).present? %>

app/components/timeline_entry/component.rb

@@ -46,14 +46,14 @@ def state_changed_vars
         old_state:
           render(
             StatusTag::Component.new(
-              status: timeline_event.old_state,
+              timeline_event.old_state,
               class_context: "timeline-event",
             ),
           ).strip,
         new_state:
           render(
             StatusTag::Component.new(
-              status: timeline_event.new_state,
+              timeline_event.new_state,
               class_context: "timeline-event",
             ),
           ).strip,

app/helpers/application_form_helper.rb

@@ -144,7 +144,7 @@ def application_form_summary_rows(
           text: I18n.t("application_form.summary.status"),
         },
         value: {
-          text: application_form_status_tags(application_form, class_context:),
+          text: application_form_status_tag(application_form, class_context:),
         },
       },
     ].compact
@@ -164,29 +164,16 @@ def application_form_display_work_history_before_teaching_qualification_banner?(
 
   private
 
-  def application_form_status_tags(application_form, class_context:)
-    if %w[overdue received waiting_on].include?(application_form.status)
-      components =
-        %w[
-          further_information
-          professional_standing
-          qualification
-          reference
-        ].filter_map do |requestable|
-          status = "#{application_form.status}_#{requestable}"
-          if application_form.send(status)
-            StatusTag::Component.new(status:, class_context:)
-          end
-        end
+  def application_form_status_tag(application_form, class_context:)
+    statuses =
+      if %w[overdue received waiting_on].include?(application_form.status)
+        %w[further_information professional_standing qualification reference]
+          .map { |requestable| "#{application_form.status}_#{requestable}" }
+          .filter { |status| application_form.send(status) }
+      else
+        application_form.status
+      end
 
-      components.map { |component| render(component) }.join(" ").html_safe
-    else
-      render(
-        StatusTag::Component.new(
-          status: application_form.status,
-          class_context:,
-        ),
-      )
-    end
+    render(StatusTag::Component.new(statuses, class_context:))
   end
 end

app/views/personas/index.html.erb

@@ -134,7 +134,7 @@
             row.with_cell { persona_check_tag(persona[:status_check]) }
             row.with_cell { persona_check_tag(persona[:sanction_check]) }
             row.with_cell do
-              render(StatusTag::Component.new(status: persona[:status]))
+              render(StatusTag::Component.new(persona[:status]))
             end
             row.with_cell { persona[:teacher].email }
 
@@ -169,7 +169,7 @@
             row.with_cell(text: reference_request.application_form.teacher.email)
 
             row.with_cell(width: "one-third") do
-              render(StatusTag::Component.new(status: reference_request.state))
+              render(StatusTag::Component.new(reference_request.state))
             end
 
             row.with_cell(numeric: true) do

spec/components/status_tag_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe StatusTag::Component, type: :component do
   subject(:component) do
-    render_inline(described_class.new(id:, status:, class_context:))
+    render_inline(described_class.new(status, id:, class_context:))
   end
 
   let(:id) { "id" }