Fix suitability record factory

This fixes issues with the factories related to suitability records.

app/models/suitability_record.rb

@@ -23,6 +23,7 @@
 #  fk_rails_...  (created_by_id => staff.id)
 #
 class SuitabilityRecord < ApplicationRecord
+  belongs_to :created_by, class_name: "Staff"
   has_and_belongs_to_many :application_forms
   has_many :emails, class_name: "SuitabilityRecord::Email"
   has_many :names, class_name: "SuitabilityRecord::Name"
@@ -39,6 +40,8 @@ def archived?
   class Email < ApplicationRecord
     self.table_name = "suitability_record_emails"
 
+    belongs_to :suitability_record
+
     validates :value, presence: true
     validates :canonical, presence: true
 
@@ -51,6 +54,8 @@ def value=(value)
   class Name < ApplicationRecord
     self.table_name = "suitability_record_names"
 
+    belongs_to :suitability_record
+
     validates :value, presence: true
   end
 end

spec/factories/suitability_records.rb

@@ -24,6 +24,8 @@
 #
 FactoryBot.define do
   factory :suitability_record do
+    association :created_by, factory: :staff
+
     note { Faker::Lorem.sentence }
 
     trait :archived do
@@ -32,16 +34,16 @@
     end
   end
 
-  factory :suitability_record_email do
+  factory :suitability_record_email, class: SuitabilityRecord::Email do
     association :suitability_record
 
-    value { Faker::Name.name }
+    value { Faker::Internet.email }
+    canonical { EmailAddress.canonical(value) }
   end
 
-  factory :suitability_record_name do
+  factory :suitability_record_name, class: SuitabilityRecord::Name do
     association :suitability_record
 
-    value { Faker::Internet.email }
-    canonical { EmailAddress.canonical(value) }
+    value { Faker::Name.name }
   end
 end