Skip to content

Commit

Permalink
Remove "Contact teaching authority" page
Browse files Browse the repository at this point in the history
This page is going to be shown on a different page now, so we need to
remove it from the verification flow.
  • Loading branch information
thomasleese committed Sep 27, 2023
1 parent 5f8145c commit d24c898
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 56 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,7 @@ def update_verify_professional_standing
session[:professional_standing] = @form.verify_professional_standing

redirect_to [
(
if @form.verify_professional_standing
:contact_professional_standing
else
:reference_requests
end
),
:reference_requests,
:assessor_interface,
application_form,
assessment,
Expand All @@ -167,10 +161,6 @@ def update_verify_professional_standing
end
end

def contact_professional_standing
authorize :assessor, :edit?
end

def edit_reference_requests
authorize :assessor, :edit?

Expand Down

This file was deleted.

3 changes: 0 additions & 3 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@
post "verify-professional-standing",
to:
"assessment_recommendation_verify#update_verify_professional_standing"
get "contact-professional-standing",
to:
"assessment_recommendation_verify#contact_professional_standing"
end

resources :further_information_requests,
Expand Down
5 changes: 0 additions & 5 deletions spec/support/page_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,6 @@ def confirm_assessment_recommendation_page
PageObjects::AssessorInterface::ConfirmAssessmentRecommendation.new
end

def contact_professional_standing_assessment_recommendation_verify_page
@contact_professional_standing_assessment_recommendation_verify_page ||=
PageObjects::AssessorInterface::ContactProfessionalStandingAssessmentRecommendationVerify.new
end

def declare_assessment_recommendation_page
@declare_assessment_recommendation_page ||=
PageObjects::AssessorInterface::DeclareAssessmentRecommendation.new
Expand Down
11 changes: 0 additions & 11 deletions spec/system/assessor_interface/completing_assessment_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,6 @@
)

when_i_select_yes_verify_professional_standing
then_i_see_the(
:contact_professional_standing_assessment_recommendation_verify_page,
application_id:,
assessment_id:,
)

when_i_click_continue_from_contact_professional_standing
then_i_see_the(
:reference_requests_assessment_recommendation_verify_page,
application_id:,
Expand Down Expand Up @@ -341,10 +334,6 @@ def when_i_select_yes_verify_professional_standing
.click
end

def when_i_click_continue_from_contact_professional_standing
contact_professional_standing_assessment_recommendation_verify_page.continue_button.click
end

def when_i_select_the_work_histories
reference_requests_assessment_recommendation_verify_page
.form
Expand Down

0 comments on commit d24c898

Please sign in to comment.