Move unsigned_consent_document_generated

This moves the column to the assessment model as the unsigned consent document only has be generated once, not per qualification.
DFE-Digital · Feb 16, 2024 · c99dc06 · c99dc06
1 parent 08009eb
commit c99dc06
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 6 deletions.
diff --git a/app/models/assessment.rb b/app/models/assessment.rb
@@ -15,6 +15,7 @@
 #  started_at                                :datetime
 #  subjects                                  :text             default([]), not null, is an Array
 #  subjects_note                             :text             default(""), not null
+#  unsigned_consent_document_generated       :boolean          default(FALSE), not null
 #  working_days_since_started                :integer
 #  working_days_started_to_recommendation    :integer
 #  working_days_submission_to_recommendation :integer

diff --git a/app/models/qualification_request.rb b/app/models/qualification_request.rb
@@ -16,7 +16,6 @@
 #  review_passed                        :boolean
 #  reviewed_at                          :datetime
 #  unsigned_consent_document_downloaded :boolean          default(FALSE), not null
-#  unsigned_consent_document_generated  :boolean          default(FALSE), not null
 #  verified_at                          :datetime
 #  verify_note                          :text             default(""), not null
 #  verify_passed                        :boolean

diff --git a/config/analytics.yml b/config/analytics.yml
@@ -80,6 +80,7 @@
     - started_at
     - subjects
     - subjects_note
+    - unsigned_consent_document_generated
     - updated_at
     - working_days_since_started
     - working_days_started_to_recommendation
@@ -222,7 +223,6 @@
     - review_passed
     - reviewed_at
     - unsigned_consent_document_downloaded
-    - unsigned_consent_document_generated
     - updated_at
     - verified_at
     - verify_note

diff --git a/db/migrate/20240216114800_add_unsigned_consent_document_generated_to_assessment.rb b/db/migrate/20240216114800_add_unsigned_consent_document_generated_to_assessment.rb
@@ -0,0 +1,17 @@
+class AddUnsignedConsentDocumentGeneratedToAssessment < ActiveRecord::Migration[
+  7.1
+]
+  def change
+    add_column :assessments,
+               :unsigned_consent_document_generated,
+               :boolean,
+               default: false,
+               null: false
+
+    remove_column :qualification_requests,
+                  :unsigned_consent_document_generated,
+                  :boolean,
+                  default: false,
+                  null: false
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/spec/factories/assessments.rb b/spec/factories/assessments.rb
@@ -15,6 +15,7 @@
 #  started_at                                :datetime
 #  subjects                                  :text             default([]), not null, is an Array
 #  subjects_note                             :text             default(""), not null
+#  unsigned_consent_document_generated       :boolean          default(FALSE), not null
 #  working_days_since_started                :integer
 #  working_days_started_to_recommendation    :integer
 #  working_days_submission_to_recommendation :integer

diff --git a/spec/factories/qualification_requests.rb b/spec/factories/qualification_requests.rb
@@ -16,7 +16,6 @@
 #  review_passed                        :boolean
 #  reviewed_at                          :datetime
 #  unsigned_consent_document_downloaded :boolean          default(FALSE), not null
-#  unsigned_consent_document_generated  :boolean          default(FALSE), not null
 #  verified_at                          :datetime
 #  verify_note                          :text             default(""), not null
 #  verify_passed                        :boolean

diff --git a/spec/models/assessment_spec.rb b/spec/models/assessment_spec.rb
@@ -17,6 +17,7 @@
 #  started_at                                :datetime
 #  subjects                                  :text             default([]), not null, is an Array
 #  subjects_note                             :text             default(""), not null
+#  unsigned_consent_document_generated       :boolean          default(FALSE), not null
 #  working_days_since_started                :integer
 #  working_days_started_to_recommendation    :integer
 #  working_days_submission_to_recommendation :integer

diff --git a/spec/models/qualification_request_spec.rb b/spec/models/qualification_request_spec.rb
@@ -16,7 +16,6 @@
 #  review_passed                        :boolean
 #  reviewed_at                          :datetime
 #  unsigned_consent_document_downloaded :boolean          default(FALSE), not null
-#  unsigned_consent_document_generated  :boolean          default(FALSE), not null
 #  verified_at                          :datetime
 #  verify_note                          :text             default(""), not null
 #  verify_passed                        :boolean