Skip to content

Commit

Permalink
2352-content-changes-ticket completed
Browse files Browse the repository at this point in the history
  • Loading branch information
syed87 committed Oct 30, 2023
1 parent d285f3f commit c6dc5c4
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 10 deletions.
2 changes: 1 addition & 1 deletion app/components/status_tag/component.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def tags
received_reference: "purple",
rejected: "red",
requested: "yellow",
review: "purple",
review: "pink",
submitted: "grey",
valid: "green",
verification: "yellow",
Expand Down
2 changes: 1 addition & 1 deletion app/models/concerns/requestable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def verify_failed?

def status
if verify_passed? || review_passed?
"accepted"
"completed"
elsif review_failed?
"rejected"
elsif verify_failed?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<h1 class="govuk-heading-xl"><%= t(".heading") %></h1>

<p class="govuk-body">If you choose to verify this applicant’s letter of professional standing, you’ll need to email the competent authority directly, then come back to record the outcome.</p>
<p class="govuk-body">If you choose to verify this application's LoPS an admin will email the competent authority and record the response.</p>

<%= f.govuk_collection_radio_buttons :verify_professional_standing, %i[true false], :itself, legend: nil %>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,18 @@

<h1 class="govuk-heading-xl"><%= title %></h1>

<p class="govuk-body">To verify the applications LoPS you need to:</p>
<p class="govuk-body">To verify the application's LoPS you need to:</p>

<ul class="govuk-list govuk-list--bullet">
<li> go to the Zendesk and apply email macro 'PR Request LoPS verification'</li>
<li> go to Zendesk and apply email macro 'PR Request LoPS verification'</li>
<li> add the applicant's details to the email</li>
<li> attach the LoPS to the email</li>
<li> find the relevant authority's and document their LoPS document</li>
<li> find the relevant authority’s details on the LoPS document</li>
<li> send the email to the relevant teaching authority</li>
</ul>

<p class="govuk-body">
Do you want to mark this task as completed and come back after you have sent the email from Zendesk?
Do you want to mark this task as completed or come back after you have sent the email from Zendesk?
</p>

<%= form_with model: @form, url: [:request, :assessor_interface, @application_form, @assessment, :professional_standing_request] do |f| %>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<h1 class="govuk-heading-xl">Verify LoPS</h1>

<p class="govuk-body">
You need to request verification for this applications LoPS. Follow the steps below:
You need to request verification for this application's LoPS.
</p>

<%= render(TaskList::Component.new(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@

<h1 class="govuk-heading-xl">Review verifications</h1>

<p class="govuk-body">
The following verification tasks ahve been flagged for review:
</p>

<%= govuk_table do |table|
if @professional_standing_request.present?
table.with_caption(text: "LoPS")
Expand Down
2 changes: 1 addition & 1 deletion spec/support/shared_examples/requestable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
it "is accepted when passed is true" do
subject.review_passed = true
subject.reviewed_at = Time.zone.now
expect(subject.status).to eq("accepted")
expect(subject.status).to eq("completed")
end

it "is rejected when passed is false" do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def when_i_verify_the_reference_request
def then_i_see_the_reference_request_status_is_accepted
expect(
assessor_reference_requests_page.task_list.status_tags.first.text,
).to eq("ACCEPTED")
).to eq("COMPLETED")
end

def when_i_verify_that_all_references_are_accepted
Expand Down

0 comments on commit c6dc5c4

Please sign in to comment.