Fix testing race condition

This fixes a race condition issue in the tests where we need to make
sure objects are defined before trying to use them.

spec/view_objects/assessor_interface/application_forms_index_view_object_spec.rb

@@ -103,14 +103,15 @@
     end
 
     context "with multiple application forms" do
-      let(:application_form_1) do
+      let!(:application_form_1) do
         create(
           :application_form,
           :submitted,
           submitted_at: Date.new(2020, 1, 1),
         )
       end
-      let(:application_form_2) do
+
+      let!(:application_form_2) do
         create(
           :application_form,
           :submitted,