Add filename to uploads

This adds a new column to the upload model which we'll use to store the
filename. This is necessary as we delete attachments if they're scanned
as a virus, so we need to store the name elsewhere so it can be
rendered.

app/forms/concerns/uploadable_form.rb

@@ -27,13 +27,15 @@ def create_uploads!
     if original_attachment.present?
       document.uploads.create!(
         attachment: original_attachment,
+        filename: original_attachment.filename,
         translation: false,
       )
     end
 
     if translated_attachment.present?
       document.uploads.create!(
         attachment: translated_attachment,
+        filename: translated_attachment.filename,
         translation: true,
       )
     end

app/models/upload.rb

@@ -3,6 +3,7 @@
 # Table name: uploads
 #
 #  id                  :bigint           not null, primary key
+#  filename            :string           default(""), not null
 #  malware_scan_result :string           default("pending"), not null
 #  translation         :boolean          not null
 #  created_at          :datetime         not null

config/analytics.yml

@@ -390,12 +390,13 @@
     - updated_at
     - work_history_id
   :uploads:
-    - id
+    - created_at
     - document_id
+    - filename
+    - id
+    - malware_scan_result
     - translation
-    - created_at
     - updated_at
-    - malware_scan_result
   :work_histories:
     - application_form_id
     - canonical_contact_email

db/migrate/20240410150439_add_filename_to_uploads.rb

@@ -0,0 +1,5 @@
+class AddFilenameToUploads < ActiveRecord::Migration[7.1]
+  def change
+    add_column :uploads, :filename, :string, null: false, default: ""
+  end
+end

lib/tasks/uploads.rake

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+namespace :uploads do
+  desc "Resend blob data for uploads that have a pending malware scan result"
+  task update_filename: :environment do
+    Upload
+      .where(filename: "")
+      .with_attached_attachment
+      .find_each do |upload|
+        upload.update!(filename: upload.attachment.filename || "unknown")
+      end
+  end
+end

spec/factories/uploads.rb

@@ -3,6 +3,7 @@
 # Table name: uploads
 #
 #  id                  :bigint           not null, primary key
+#  filename            :string           default(""), not null
 #  malware_scan_result :string           default("pending"), not null
 #  translation         :boolean          not null
 #  created_at          :datetime         not null

spec/models/upload_spec.rb

@@ -3,6 +3,7 @@
 # Table name: uploads
 #
 #  id                  :bigint           not null, primary key
+#  filename            :string           default(""), not null
 #  malware_scan_result :string           default("pending"), not null
 #  translation         :boolean          not null
 #  created_at          :datetime         not null