Remove email consent letters page

We don't need this page anymore as the consent letters are going to be part of the admin journey.
DFE-Digital · Dec 22, 2023 · 846f91a · 846f91a
1 parent 1f0b71c
commit 846f91a
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 72 deletions.
diff --git a/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb b/app/controllers/assessor_interface/assessment_recommendation_verify_controller.rb
@@ -106,7 +106,7 @@ def update_qualification_requests
 
       if @form.save
         redirect_to [
-                      :email_consent_letters,
+                      :professional_standing,
                       :assessor_interface,
                       application_form,
                       assessment,
@@ -117,13 +117,6 @@ def update_qualification_requests
       end
     end
 
-    def email_consent_letters
-      authorize %i[assessor_interface assessment_recommendation], :edit?
-
-      @qualifications =
-        application_form.qualifications.where(id: session[:qualification_ids])
-    end
-
     def edit_professional_standing
       authorize %i[assessor_interface assessment_recommendation], :edit?
 

diff --git a/app/views/assessor_interface/assessment_recommendation_verify/email_consent_letters.html.erb b/app/views/assessor_interface/assessment_recommendation_verify/email_consent_letters.html.erb
diff --git a/config/locales/assessor_interface.en.yml b/config/locales/assessor_interface.en.yml
@@ -93,8 +93,6 @@ en:
         heading: Request work history references
       edit_professional_standing:
         heading: Do you want to verify LoPS?
-      email_consent_letters:
-        heading: Email consent letters
       preview_referee:
         heading: Check and send the reference request email
       preview_teacher:

diff --git a/config/routes.rb b/config/routes.rb
@@ -89,8 +89,6 @@
           post "qualification-requests",
                to:
                  "assessment_recommendation_verify#update_qualification_requests"
-          get "email-consent-letters",
-              to: "assessment_recommendation_verify#email_consent_letters"
           get "reference-requests",
               to: "assessment_recommendation_verify#edit_reference_requests"
           post "reference-requests",

diff --git a/...page_objects/assessor_interface/email_consent_letters_assessment_recommendation_verify.rb b/...page_objects/assessor_interface/email_consent_letters_assessment_recommendation_verify.rb
diff --git a/spec/support/page_helpers.rb b/spec/support/page_helpers.rb
@@ -117,11 +117,6 @@ def assessor_edit_work_history_page
       PageObjects::AssessorInterface::EditWorkHistory.new
   end
 
-  def assessor_email_consent_letters_requests_assessment_recommendation_verify_page
-    @assessor_email_consent_letters_requests_assessment_recommendation_verify_page ||=
-      PageObjects::AssessorInterface::EmailConsentLettersAssessmentRecommendationVerify.new
-  end
-
   def assessor_further_information_request_page
     @assessor_further_information_request_page ||=
       PageObjects::AssessorInterface::FurtherInformationRequest.new

diff --git a/spec/system/assessor_interface/completing_assessment_spec.rb b/spec/system/assessor_interface/completing_assessment_spec.rb
@@ -108,13 +108,6 @@
     )
 
     when_i_select_the_qualifications
-    then_i_see_the(
-      :assessor_email_consent_letters_requests_assessment_recommendation_verify_page,
-      reference:,
-      assessment_id:,
-    )
-
-    when_i_click_continue_from_email_consent_letters
     then_i_see_the(
       :assessor_professional_standing_assessment_recommendation_verify_page,
       reference:,
@@ -345,10 +338,6 @@ def when_i_select_the_qualifications
       .click
   end
 
-  def when_i_click_continue_from_email_consent_letters
-    assessor_email_consent_letters_requests_assessment_recommendation_verify_page.continue_button.click
-  end
-
   def when_i_select_yes_verify_professional_standing
     assessor_professional_standing_assessment_recommendation_verify_page
       .form